Mesa (master): x11: take ownership rather than adding reference for new renderbuffers

Timothy Arceri tarceri at kemper.freedesktop.org
Mon Apr 10 01:06:09 UTC 2017


Module: Mesa
Branch: master
Commit: d9fe82fe4198425cd42081e7fd5bd7ac69aacdd2
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=d9fe82fe4198425cd42081e7fd5bd7ac69aacdd2

Author: Timothy Arceri <tarceri at itsqueeze.com>
Date:   Sat Apr  8 10:47:12 2017 +1000

x11: take ownership rather than adding reference for new renderbuffers

This avoids locking in the reference calls and fixes a leak after the
RefCount initialisation was change from 0 to 1.

Fixes: 32141e53d1520 (mesa: tidy up renderbuffer RefCount initialisation)

Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

---

 src/mesa/drivers/x11/xm_api.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/mesa/drivers/x11/xm_api.c b/src/mesa/drivers/x11/xm_api.c
index 82c4d188d5..5be8aa95de 100644
--- a/src/mesa/drivers/x11/xm_api.c
+++ b/src/mesa/drivers/x11/xm_api.c
@@ -311,8 +311,8 @@ create_xmesa_buffer(XMesaDrawable d, BufferType type,
    b->frontxrb->Parent = b;
    b->frontxrb->drawable = d;
    b->frontxrb->pixmap = (XMesaPixmap) d;
-   _mesa_add_renderbuffer(&b->mesa_buffer, BUFFER_FRONT_LEFT,
-                          &b->frontxrb->Base.Base);
+   _mesa_add_renderbuffer_without_ref(&b->mesa_buffer, BUFFER_FRONT_LEFT,
+                                      &b->frontxrb->Base.Base);
 
    /*
     * Back renderbuffer
@@ -328,8 +328,8 @@ create_xmesa_buffer(XMesaDrawable d, BufferType type,
       /* determine back buffer implementation */
       b->db_mode = vis->ximage_flag ? BACK_XIMAGE : BACK_PIXMAP;
       
-      _mesa_add_renderbuffer(&b->mesa_buffer, BUFFER_BACK_LEFT,
-                             &b->backxrb->Base.Base);
+      _mesa_add_renderbuffer_without_ref(&b->mesa_buffer, BUFFER_BACK_LEFT,
+                                         &b->backxrb->Base.Base);
    }
 
    /*




More information about the mesa-commit mailing list