Mesa (master): ac: add unreachable() in ac_build_image_opcode()

Samuel Pitoiset hakzsam at kemper.freedesktop.org
Mon Apr 10 21:08:52 UTC 2017


Module: Mesa
Branch: master
Commit: a1c37ff9e4cfea0a645a15634299ef7d55362b09
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=a1c37ff9e4cfea0a645a15634299ef7d55362b09

Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date:   Fri Apr  7 18:44:16 2017 +0200

ac: add unreachable() in ac_build_image_opcode()

To silent the following compiler warning:

common/ac_llvm_build.c: In function ‘ac_build_image_opcode’:
common/ac_llvm_build.c:1080:3: warning: ‘name’ may be used uninitialized in this function [-Wmaybe-uninitialized]
   snprintf(intr_name, sizeof(intr_name), "%s%s%s%s.v4f32.%s.v8i32",
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    name,
    ~~~~~
    a->compare ? ".c" : "",
    ~~~~~~~~~~~~~~~~~~~~~~~
    a->bias ? ".b" :
    ~~~~~~~~~~~~~~~~
    a->lod ? ".l" :
    ~~~~~~~~~~~~~~~
    a->deriv ? ".d" :
    ~~~~~~~~~~~~~~~~~
    a->level_zero ? ".lz" : "",
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~
    a->offset ? ".o" : "",
    ~~~~~~~~~~~~~~~~~~~~~~
    type);
    ~~~~~

Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Marek Olšák <marek.olsak at amd.com>

---

 src/amd/common/ac_llvm_build.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/common/ac_llvm_build.c
index 5745fab05f..d45094c862 100644
--- a/src/amd/common/ac_llvm_build.c
+++ b/src/amd/common/ac_llvm_build.c
@@ -1072,6 +1072,8 @@ LLVMValueRef ac_build_image_opcode(struct ac_llvm_context *ctx,
 		case ac_image_get_resinfo:
 			name = "llvm.amdgcn.image.getresinfo";
 			break;
+		default:
+			unreachable("invalid image opcode");
 		}
 
 		ac_build_type_name_for_intr(LLVMTypeOf(args[0]), type,




More information about the mesa-commit mailing list