Mesa (master): glsl: remove duplicate validation

Timothy Arceri tarceri at kemper.freedesktop.org
Wed Apr 26 22:21:40 UTC 2017


Module: Mesa
Branch: master
Commit: f8a2d000460854b825a84550c6068c7d123edff9
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=f8a2d000460854b825a84550c6068c7d123edff9

Author: Timothy Arceri <tarceri at itsqueeze.com>
Date:   Wed Apr 26 13:56:45 2017 +1000

glsl: remove duplicate validation

Varying types have already been validated in
apply_type_qualifier_to_variable() by this point.

Reviewed-by: Alejandro Piñeiro <apinheiro at igalia.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>

---

 src/compiler/glsl/ast_to_hir.cpp | 15 ---------------
 1 file changed, 15 deletions(-)

diff --git a/src/compiler/glsl/ast_to_hir.cpp b/src/compiler/glsl/ast_to_hir.cpp
index 0ae87cb93e..ef6f6cc08d 100644
--- a/src/compiler/glsl/ast_to_hir.cpp
+++ b/src/compiler/glsl/ast_to_hir.cpp
@@ -5035,21 +5035,6 @@ ast_declarator_list::hir(exec_list *instructions,
 
          /* From section 4.3.6 (Output variables) of the GLSL 4.40 spec:
           *
-          *     It is a compile-time error to declare a vertex, tessellation
-          *     evaluation, tessellation control, or geometry shader output
-          *     that contains any of the following:
-          *
-          *     * A Boolean type (bool, bvec2 ...)
-          *     * An opaque type
-          */
-         if (check_type->is_boolean() || check_type->contains_opaque())
-            _mesa_glsl_error(&loc, state,
-                             "%s shader output cannot have type %s",
-                             _mesa_shader_stage_to_string(state->stage),
-                             check_type->name);
-
-         /* From section 4.3.6 (Output variables) of the GLSL 4.40 spec:
-          *
           *     It is a compile-time error to declare a fragment shader output
           *     that contains any of the following:
           *




More information about the mesa-commit mailing list