Mesa (master): glsl: fix error when using format qualifiers with non-image types

Samuel Pitoiset hakzsam at kemper.freedesktop.org
Fri Apr 28 08:47:24 UTC 2017


Module: Mesa
Branch: master
Commit: 80738425e4d3240c43cac1b4cfde91650379cf5c
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=80738425e4d3240c43cac1b4cfde91650379cf5c

Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date:   Wed Apr 26 18:50:14 2017 +0200

glsl: fix error when using format qualifiers with non-image types

Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>

---

 src/compiler/glsl/ast_to_hir.cpp | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/compiler/glsl/ast_to_hir.cpp b/src/compiler/glsl/ast_to_hir.cpp
index ef6f6cc08d..425da639c7 100644
--- a/src/compiler/glsl/ast_to_hir.cpp
+++ b/src/compiler/glsl/ast_to_hir.cpp
@@ -3304,11 +3304,15 @@ apply_image_qualifier_to_variable(const struct ast_type_qualifier *qual,
           qual->flags.q.write_only ||
           qual->flags.q.coherent ||
           qual->flags.q._volatile ||
-          qual->flags.q.restrict_flag ||
-          qual->flags.q.explicit_image_format) {
+          qual->flags.q.restrict_flag) {
          _mesa_glsl_error(loc, state, "memory qualifiers may only be applied "
                           "to images");
       }
+
+      if (qual->flags.q.explicit_image_format) {
+         _mesa_glsl_error(loc, state, "format layout qualifiers may only be "
+                          "applied to images");
+      }
       return;
    }
 




More information about the mesa-commit mailing list