Mesa (master): egl/x11: don't leak xfixes_query in the error path

Emil Velikov evelikov at kemper.freedesktop.org
Fri Aug 4 23:02:32 UTC 2017


Module: Mesa
Branch: master
Commit: c961b679fe16fc98c3d04d611abc287f1bcc07b5
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=c961b679fe16fc98c3d04d611abc287f1bcc07b5

Author: Emil Velikov <emil.velikov at collabora.com>
Date:   Thu Aug  3 14:34:53 2017 +0100

egl/x11: don't leak xfixes_query in the error path

If we get a xfixes v1.x we'll error out, without freeing the
xfixes_query reply.

Cc: <mesa-stable at lists.freedesktop.org>
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>

---

 src/egl/drivers/dri2/platform_x11.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/egl/drivers/dri2/platform_x11.c b/src/egl/drivers/dri2/platform_x11.c
index 35c62a4975..61e700f7ec 100644
--- a/src/egl/drivers/dri2/platform_x11.c
+++ b/src/egl/drivers/dri2/platform_x11.c
@@ -646,6 +646,7 @@ dri2_x11_connect(struct dri2_egl_display *dri2_dpy)
        error != NULL || xfixes_query->major_version < 2) {
       _eglLog(_EGL_WARNING, "DRI2: failed to query xfixes version");
       free(error);
+      free(xfixes_query);
       return EGL_FALSE;
    }
    free(xfixes_query);




More information about the mesa-commit mailing list