Mesa (master): TextureStorage1D should return INVALID_OPERATION if target is not a 1D texture

Iago Toral Quiroga itoral at kemper.freedesktop.org
Wed Aug 9 07:29:45 UTC 2017


Module: Mesa
Branch: master
Commit: 0415ef9ccd06388c8f60726032f0814b66850312
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=0415ef9ccd06388c8f60726032f0814b66850312

Author: Iago Toral Quiroga <itoral at igalia.com>
Date:   Mon Aug  7 06:18:24 2017 +0200

TextureStorage1D should return INVALID_OPERATION if target is not a 1D texture

Previous behavior was inconsistent with other texture targets so this has been
fixed in OpenGL 4.6.

Fixes:
KHR-GL45.direct_state_access.textures_storage_errors

Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>

---

 src/mesa/main/texstorage.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mesa/main/texstorage.c b/src/mesa/main/texstorage.c
index e0930abe3f..44edba3323 100644
--- a/src/mesa/main/texstorage.c
+++ b/src/mesa/main/texstorage.c
@@ -605,7 +605,7 @@ texturestorage_error(GLuint dims, GLuint texture, GLsizei levels,
     * can receive unsized formats.
     */
    if (!legal_texobj_target(ctx, dims, texObj->Target)) {
-      _mesa_error(ctx, GL_INVALID_ENUM,
+      _mesa_error(ctx, GL_INVALID_OPERATION,
                   "%s(illegal target=%s)", caller,
                   _mesa_enum_to_string(texObj->Target));
       return;




More information about the mesa-commit mailing list