Mesa (master): st/dri2: fix kms_swrast driconf option handling
Rob Herring
robh at kemper.freedesktop.org
Wed Aug 9 14:13:46 UTC 2017
Module: Mesa
Branch: master
Commit: cc43c4a9e56a5f6dd66e6e67074c219e6f87ba26
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=cc43c4a9e56a5f6dd66e6e67074c219e6f87ba26
Author: Rob Herring <robh at kernel.org>
Date: Tue Aug 8 11:42:02 2017 -0500
st/dri2: fix kms_swrast driconf option handling
Commit e794f8bf8bdb ("gallium: move loading of drirc to pipe-loader")
moved the option cache to the pipe_loader_device. However, the
screen->dev pointer is not set when dri_init_options() is called. Move
the call to after the pipe_loader_sw_probe_kms() call so screen->dev is
set. This mirrors the code flow for dri2_init_screen().
Fixes: e794f8bf8bdb ("gallium: move loading of drirc to pipe-loader")
Reviewed-by: Nicolai Hähnle <nicolai.haehnle at amd.com>
Cc: Marek Olšák <marek.olsak at amd.com>
Signed-off-by: Rob Herring <robh at kernel.org>
---
src/gallium/state_trackers/dri/dri2.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/gallium/state_trackers/dri/dri2.c b/src/gallium/state_trackers/dri/dri2.c
index 4e58bcb9c5..1e8bb48104 100644
--- a/src/gallium/state_trackers/dri/dri2.c
+++ b/src/gallium/state_trackers/dri/dri2.c
@@ -2061,10 +2061,10 @@ dri_kms_init_screen(__DRIscreen * sPriv)
if (screen->fd < 0 || (fd = fcntl(screen->fd, F_DUPFD_CLOEXEC, 3)) < 0)
goto free_screen;
- dri_init_options(screen);
-
- if (pipe_loader_sw_probe_kms(&screen->dev, fd))
+ if (pipe_loader_sw_probe_kms(&screen->dev, fd)) {
+ dri_init_options(screen);
pscreen = pipe_loader_create_screen(screen->dev);
+ }
if (!pscreen)
goto release_pipe;
More information about the mesa-commit
mailing list