Mesa (master): glsl: set old ldexp operand to NULL when lowering

Timothy Arceri tarceri at kemper.freedesktop.org
Fri Aug 18 02:07:44 UTC 2017


Module: Mesa
Branch: master
Commit: c03eefdf843098c93c8e95856e0e482a60915590
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=c03eefdf843098c93c8e95856e0e482a60915590

Author: Timothy Arceri <tarceri at itsqueeze.com>
Date:   Fri Aug 18 09:32:15 2017 +1000

glsl: set old ldexp operand to NULL when lowering

This fixes an assert during IR validation in LLVMpipe.

Fixes: e2e2c5abd279 (glsl: calculate number of operands in an expression once)
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102274
Reviewed-by: Brian Paul <brianp at vmware.com>
Tested-by: Brian Paul <brianp at vmware.com>

---

 src/compiler/glsl/lower_instructions.cpp | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/compiler/glsl/lower_instructions.cpp b/src/compiler/glsl/lower_instructions.cpp
index dfce900a16..0c1408911d 100644
--- a/src/compiler/glsl/lower_instructions.cpp
+++ b/src/compiler/glsl/lower_instructions.cpp
@@ -482,6 +482,7 @@ lower_instructions_visitor::ldexp_to_arith(ir_expression *ir)
       ir->init_num_operands();
       ir->operands[0] = bit_or(bit_and(bitcast_f2u(x), sign_mantissa_mask),
                                lshift(i2u(resulting_biased_exp), exp_shift_clone));
+      ir->operands[1] = NULL;
    }
 
    this->progress = true;




More information about the mesa-commit mailing list