Mesa (17.1): 25 new commits

Andres Gomez tanty at kemper.freedesktop.org
Sat Aug 19 14:49:48 UTC 2017


URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=d39095e3502df95f3a203d311c6a20a6b94bcfa2
Author: Andres Gomez <agomez at igalia.com>
Date:   Thu Aug 17 22:34:22 2017 +0300

    cherry-ignore: add "radv: handle 10-bit format clamping workaround."
    
    fixes: This commit is complex and has non trivial conflicts due to
    previous changes.
    
    Signed-off-by: Andres Gomez <agomez at igalia.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=bee9130910449ca5a05ee1435c36e68fda3f950c
Author: Andres Gomez <agomez at igalia.com>
Date:   Thu Aug 17 22:29:28 2017 +0300

    cherry-ignore: add "virgl: drop precise modifier."
    
    fixes: This commit addressed an earlier commit af22adee4f which did
    not land in branch.
    
    Signed-off-by: Andres Gomez <agomez at igalia.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=acbb7c0dad30ba720fe50bd1b250c5c1346efbc0
Author: Andres Gomez <agomez at igalia.com>
Date:   Thu Aug 17 22:27:49 2017 +0300

    cherry-ignore: add "radv: Handle VK_ATTACHMENT_UNUSED in color attachments."
    
    fixes: This commit is complex and has non trivial conflicts due to
    multiple previous changes.
    
    Signed-off-by: Andres Gomez <agomez at igalia.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=7405f9078fc7007e8fa68f187822fe4685ba9e46
Author: Andres Gomez <agomez at igalia.com>
Date:   Thu Aug 17 16:56:55 2017 +0300

    cherry-ignore: added 17.2 nominations.
    
    stable: 17.2 nominations only.
    
    Signed-off-by: Andres Gomez <agomez at igalia.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=b49a1b69f87ed656a7f56a97c1a83ee79e8b6f68
Author: Andres Gomez <agomez at igalia.com>
Date:   Thu Aug 17 17:47:56 2017 +0300

    cherry-ignore: add "configure: remove trailing "-a" in swr architecture teststable: 17.2 nomination only."
    
    stable: 17.2 nomination only. Depends on earlier commit 1cb5a6061c
    which did not land in branch.
    
    Signed-off-by: Andres Gomez <agomez at igalia.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=239e065e5d1308841d3e1f73097b29c3b47acda5
Author: Andres Gomez <agomez at igalia.com>
Date:   Thu Aug 17 15:54:46 2017 +0300

    cherry-ignore: add "radeon/ac: use ds_swizzle for derivs on si/cik."
    
    stable: Depends on earlier commit 28634ff7d3 which did not land in
    branch.
    
    Signed-off-by: Andres Gomez <agomez at igalia.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=e7b564c7ea078fb22994be4fbe50c3ddee70ed5d
Author: Andres Gomez <agomez at igalia.com>
Date:   Thu Aug 17 15:53:36 2017 +0300

    cherry-ignore: add "swr: use the correct variable for no undefined symbols"
    
    stable: Breaks SWR compilation due to earlier commit f50aa21456 which
    did not land in branch.
    
    Signed-off-by: Andres Gomez <agomez at igalia.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=c19c497ae6dc39bd072f6b2fd420cf77caa2a23f
Author: Eric Anholt <eric at anholt.net>
Date:   Mon Jul 31 14:47:12 2017 -0700

    util: Fix build on old glibc.
    
    We need to link librt for u_thread.h's clock_gettime() call.
    
    Fixes: b822d9dd67b5 ("gallium/util: move u_queue.{c,h} to src/util")
    Reviewed-by: Matt Turner <mattst88 at gmail.com>
    (cherry picked from commit b94ddc181bc514bd32c1d4103aa1c7582a7a60ff)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=91507eb6788c7c7d761c241dc26fd2a00bc74f49
Author: Dave Airlie <airlied at redhat.com>
Date:   Wed Jul 26 04:37:53 2017 +0100

    radv: force cs/ps/l2 flush at end of command stream. (v2)
    
    This seems like a workaround, but we don't see the bug on CIK/VI.
    
    On SI with the dEQP-VK.memory.pipeline_barrier.host_read_transfer_dst.*
    tests, when one tests complete, the first flush at the start of the next
    test causes a VM fault as we've destroyed the VM, but we end up flushing
    the compute shader then, and it must still be in the process of doing
    something.
    
    Could also be a kernel difference between SI and CIK.
    
    v2: hit this with a bigger hammer. This fixes a bunch of hangs
    in the vk cts with the robustness tests.
    
    Fixes: f4e499ec791 ("radv: add initial non-conformant radv vulkan driver")
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101334
    Acked-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
    Signed-off-by: Dave Airlie <airlied at redhat.com>
    (cherry picked from commit 82ba384c10d598bee4786ef5f79e92a0e7b53892)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=bb94876b869c28e4e88fcc62f594f75d717bb117
Author: Dave Airlie <airlied at redhat.com>
Date:   Mon Aug 7 07:39:41 2017 +0100

    radv: fix MSAA on SI gpus.
    
    This ports the workaround from radeonsi, that was missing in radv.
    
    This fixes Talos rendering when MSAA is enabled on my Tahiti card.
    
    Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
    Fixes: f4e499ec7 (radv: add initial non-conformant radv vulkan driver)
    Signed-off-by: Dave Airlie <airlied at redhat.com>
    (cherry picked from commit 8bf39307517a04263532e3c5a49b5be1f4a99032)
    [Andres Gomez: resolve trivial conflicts]
    Signed-off-by: Andres Gomez <agomez at igalia.com>
    
    Conflicts:
    	src/amd/vulkan/radv_device.c

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=aaf1b2917935d51f958017d100242aa8a01cdad6
Author: Dave Airlie <airlied at redhat.com>
Date:   Fri Aug 4 00:17:34 2017 +0100

    radv: fix f16->f32 denorm handling for SI/CIK. (v2)
    
    This just copies the code from the -pro shaders,
    and fixes the tests on CIK.
    
    With this CIK passes the same set of conformance
    tests as VI.
    
    Fixes: 83e58b03 (radv: flush f32->f16 conversion denormals to zero. (v2))
    Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
    Signed-off-by: Dave Airlie <airlied at redhat.com>
    (cherry picked from commit 3f389f75b6e9b55467aca681af09b83998ee0e46)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=b0a9c185f067b95d7697ee223058b82fdca4fe24
Author: Gwan-gyeong Mun <elongbug at gmail.com>
Date:   Wed Jul 19 15:05:31 2017 +0100

    egl/drm: Fix misused x and y offsets in swrast_get_image()
    
    It fixes misused x and y variables on the calculation of the memory copy regions.
    
    Cc: Giovanni Campagna <gcampagna at src.gnome.org>
    Fixes: 8430af5ebe1ee8119e14 "Add support for swrast to the DRM EGL platform"
    Signed-off-by: Mun Gwan-gyeong <elongbug at gmail.com>
    Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>
    Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
    
    [Eric: use gbm_bo_get_bpp() instead of local function, split clamp patch]
    Signed-off-by: Eric Engestrom <eric.engestrom at imgtec.com>
    (cherry picked from commit fe2a6281b3b299998fe7399e7dbcc2077d773824)
    [Andres Gomez: resolve trivial conflicts]
    Signed-off-by: Andres Gomez <agomez at igalia.com>
    
    Conflicts:
    	src/egl/drivers/dri2/platform_drm.c

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=7050c9ab7af905a3f03c956f53441284fe229e4d
Author: Gwan-gyeong Mun <elongbug at gmail.com>
Date:   Wed Jul 19 15:05:30 2017 +0100

    egl/drm: Fix misused x and y offsets in swrast_put_image2()
    
    It fixes misused x and y variables on the calculation of the memory copy regions.
    
    Cc: Giovanni Campagna <gcampagna at src.gnome.org>
    Fixes: 8430af5ebe1ee8119e14 "Add support for swrast to the DRM EGL platform"
    Signed-off-by: Mun Gwan-gyeong <elongbug at gmail.com>
    Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>
    Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
    
    [Eric: use gbm_bo_get_bpp() instead of local function, split clamp patch]
    Signed-off-by: Eric Engestrom <eric.engestrom at imgtec.com>
    (cherry picked from commit 3a5e3aa5a53cff55a5e31766d713a41ffa5a93d7)
    [Andres Gomez: resolve trivial conflicts]
    Signed-off-by: Andres Gomez <agomez at igalia.com>
    
    Conflicts:
    	src/egl/drivers/dri2/platform_drm.c

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=67bdcff5f8a5e40da39faca1f7fb0ec8045cd101
Author: Eric Engestrom <eric at engestrom.ch>
Date:   Wed Jul 19 15:05:29 2017 +0100

    gbm: add gbm_bo_get_bpp()
    
    Signed-off-by: Eric Engestrom <eric at engestrom.ch>
    Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
    (cherry picked from commit 04a40f7d2ad8fc9556c4c3a8742bbf2c948d28a0)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=75ce282ee243272e937275c6d086b5a391f8ca47
Author: Ilia Mirkin <imirkin at alum.mit.edu>
Date:   Wed Aug 16 00:33:34 2017 -0400

    nv50/ir: fix TXQ srcMask
    
    src0.x is always read for the LOD, irrespective of which outputs are
    read.
    
    Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
    Cc: mesa-stable at lists.freedesktop.org
    (cherry picked from commit 934511d1f3a8e2e9b0091d725c87a22a51233141)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=37e61310e3673de8c23fdb1c1c5181a5e1cdc116
Author: Ilia Mirkin <imirkin at alum.mit.edu>
Date:   Wed Aug 16 00:25:40 2017 -0400

    nv50/ir: fix srcMask computation for TG4 and TXF
    
    This affects which inputs are marked as used. In a situation where only
    the texture instruction uses an input, it might have been ignored as
    unused due to input masks.
    
    Affects subtests of KHR-GL45.texture_cube_map_array.sampling
    
    Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
    Cc: mesa-stable at lists.freedesktop.org
    (cherry picked from commit 054c54d1be634dec106c30030bb4921f398d6c90)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=baf8c7b1c4bccbda9e2f9fd09d3647cb0f7027e6
Author: Frank Richter <frank.richter at dynardo.de>
Date:   Tue Aug 15 15:46:35 2017 +0200

    gallium/os: fix os_time_get_nano() to roll over less
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102241
    Cc: mesa-stable at lists.freedesktop.org
    Reviewed-by: Brian Paul <brianp at vmware.com>
    Reviewed-by: Jose Fonseca <jfonseca at vmware.com>
    (cherry picked from commit 7fb7287ce72066db7dffd918226bf15c3131a871)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=313fc5331d525e2f597cbc7acf96cb66ee4784d5
Author: Frank Richter <frank.richter at dynardo.de>
Date:   Mon Aug 14 16:05:22 2017 +0200

    st/wgl: check for negative delta in wait_swap_interval()
    
    This can happen because of rollover.  See bug report for details.
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102241
    Cc: mesa-stable at lists.freedesktop.org
    Reviewed-by: Brian Paul <brianp at vmware.com>
    Reviewed-by: Jose Fonseca <jfonseca at vmware.com>
    (cherry picked from commit d90e05ad487e9fe7e17c293814ac8549d9d686d8)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=e4db525e82f838b7faa62d6679f550ce5eebc795
Author: Frank Richter <frank.richter at dynardo.de>
Date:   Wed Jun 7 14:40:23 2017 +0200

    st/mesa: fix a null pointer access
    
    Fixes crash with llvmpipe on Windows.
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102148
    Cc: mesa-stable at lists.freedesktop.org
    Reviewed-by: Brian Paul <brianp at vmware.com>
    (cherry picked from commit 496a691e3544d082670ac1f33059692510a2a86d)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=ed594f19d76f8ba0c010bf978e5fe542edc777d5
Author: Tim Rowley <timothy.o.rowley at intel.com>
Date:   Mon Aug 7 20:33:24 2017 -0500

    swr/rast: Fix invalid casting for calls to Interlocked* functions
    
    CID: 1416243, 1416244, 1416255
    CC: mesa-stable at lists.freedesktop.org
    Reviewed-by: Bruce Cherniak <bruce.cherniak at intel.com>
    (cherry picked from commit b333bc753e2dd1ed1a676606046a4289e7d58187)
    [Andres Gomez: resolve trivial conflicts]
    Signed-off-by: Andres Gomez <agomez at igalia.com>
    
    Conflicts:
    	src/gallium/drivers/swr/rasterizer/core/api.cpp
    	src/gallium/drivers/swr/rasterizer/core/threads.cpp

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=4e993fc542c47434a7d3d6998141df607867a30f
Author: Ilia Mirkin <imirkin at alum.mit.edu>
Date:   Tue Aug 15 13:47:08 2017 -0400

    glsl/ast: update rhs in addition to the var's constant_value
    
    We continue in the code to do some more things with the rhs, including
    setting a constant initializer. If the type is wrong, this causes some
    confusion down the line, leading to assertions. This makes sure that the
    rhs processing continues to flow as-if the type was correct to start
    with (even though the state has been marked as an error state).
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101766
    Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
    Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
    Cc: mesa-stable at lists.freedesktop.org
    (cherry picked from commit 978c4c597aa48e65bd6822a85e6b8f82ca9281f1)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=e05ea17c50fe5053b1a4388eb39b26e5060aa349
Author: Marek Olšák <marek.olsak at amd.com>
Date:   Sun Aug 13 19:22:06 2017 +0200

    radeonsi: disable CE by default
    
    It makes performance worse by a very small (hard to measure) amount.
    We've done extensive profiling of this feature internally.
    
    Cc: 17.1 17.2 <mesa-stable at lists.freedesktop.org>
    Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
    Acked-by: Christian König <christian.koenig at amd.com>
    (cherry picked from commit 1ab7fed7079a8b0f670d6a51ddc98691ace29508)
    [Andres Gomez: resolve trivial conflicts]
    Signed-off-by: Andres Gomez <agomez at igalia.com>
    
    Conflicts:
    	src/gallium/drivers/radeonsi/si_pipe.c

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=774e77ab64de05d437939110dd11c35a300d47f6
Author: Emil Velikov <emil.velikov at collabora.com>
Date:   Tue Aug 8 15:55:36 2017 +0100

    egl: avoid eglCreatePlatform*Surface{EXT,} crash with invalid dpy
    
    If we have an invalid display fed into the functions, the display lookup
    will return NULL. Thus as we attempt to get the platform type, we'll
    deref. it leading to a crash.
    
    Keep in mind that this will not happen if Mesa is built without X11 or
    when the legacy eglCreate*Surface codepaths are used.
    
    A similar check was added with earlier commit 5e97b8f5ce9 ("egl: Fix
    crashes in eglCreate*Surface), although it was only applicable when the
    surfaceless platform is built.
    
    Cc: mesa-stable at lists.freedesktop.org
    Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
    Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>
    Reviewed-by: Tapani Pälli <tapani.palli at intel.com>
    (cherry picked from commit 26fbb9eacddb1b809739cb12477bde13501d6d5a)
    [Andres Gomez: resolve trivial conflicts]
    Signed-off-by: Andres Gomez <agomez at igalia.com>
    
    Conflicts:
    	src/egl/main/eglapi.c

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=c968de1989026388f690cf41913f47f45c7abbe8
Author: Marek Olšák <marek.olsak at amd.com>
Date:   Wed Aug 9 22:30:28 2017 +0200

    ac: fail shader compilation if libelf is replaced by an incompatible version
    
    UE4Editor has this issue.
    
    This commit prevents hangs (release build) or assertion failures (debug
    build). It doesn't fix the editor, but catastrophic scenarios are
    prevented.
    
    Cc: 17.1 17.2 <mesa-stable at lists.freedesktop.org>
    Reviewed-by: Michel Dänzer <michel.daenzer at amd.com>
    Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
    (cherry picked from commit 4630ede1021d49c610de1274dc9d1006b843e46b)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=8aa358bd69862d4a88148942c85ee74048fa2561
Author: Karol Herbst <karolherbst at gmail.com>
Date:   Sun Jul 30 17:51:22 2017 +0200

    nv50/ir: fix ConstantFolding with saturation
    
    For mul(a, +-1) codegen can generate OP_MOV with a saturation flag
    set which is ignored at emission. The same can happen with add(a, 0),
    and others.
    
    Adding an assert for detecting more of such issues.
    
    Fixes wrongly rendered water in Hitman Absolution running under wine.
    Also a few shaders in Mad Max and Alien Isolation produce such MOVs.
    
    CC: <mesa-stable at lists.freedesktop.org>
    Signed-off-by: Karol Herbst <karolherbst at gmail.com>
    Reviewed-by: Tobias Klausmann <tobias.johannes.klausmann at mni.thm.de>
    [imirkin: generalize the fix for other cases]
    Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>
    (cherry picked from commit 24a799ad35a824fba94062f9b018f603717ed145)
    
    squashed with:
    
    nv50/ir: clean up saturated values immediately
    
    Since we don't iterate to a fixed point, we can end up in situations
    where we have a SAT instruction + a long immediate. This is not legal.
    However since it's immediately computable, just run unary straight away
    to handle the situation.
    
    Fixes: 24a799ad35a82 ("nv50/ir: fix ConstantFolding with saturation")
    Reported-by: Tobias Klausmann <tobias.johannes.klausmann at mni.thm.de>
    Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
    Cc: mesa-stable at lists.freedesktop.org
    (cherry picked from commit 165e18dd219fbf4d60fd582b02e2dbf75ccd026f)




More information about the mesa-commit mailing list