Mesa (master): i965: Drop unnecessary conditional

Matt Turner mattst88 at kemper.freedesktop.org
Tue Aug 29 22:21:06 UTC 2017


Module: Mesa
Branch: master
Commit: dff75c7175d7a06cdeafa5c119f3749e84e2561b
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=dff75c7175d7a06cdeafa5c119f3749e84e2561b

Author: Matt Turner <mattst88 at gmail.com>
Date:   Fri Aug 25 19:22:51 2017 -0700

i965: Drop unnecessary conditional

Clang doesn't realize that 0 and 1 are the only possibilities, a thinks
lots of variables might be uninitialized.

Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>

---

 src/intel/compiler/brw_eu_validate.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/intel/compiler/brw_eu_validate.c b/src/intel/compiler/brw_eu_validate.c
index 249342fb9d..b24b38170e 100644
--- a/src/intel/compiler/brw_eu_validate.c
+++ b/src/intel/compiler/brw_eu_validate.c
@@ -555,7 +555,7 @@ general_restrictions_on_region_parameters(const struct gen_device_info *devinfo,
 
       if (i == 0) {
          DO_SRC(0);
-      } else if (i == 1) {
+      } else {
          DO_SRC(1);
       }
 #undef DO_SRC
@@ -758,7 +758,7 @@ region_alignment_rules(const struct gen_device_info *devinfo,
 
       if (i == 0) {
          DO_SRC(0);
-      } else if (i == 1) {
+      } else {
          DO_SRC(1);
       }
 #undef DO_SRC
@@ -950,7 +950,7 @@ region_alignment_rules(const struct gen_device_info *devinfo,
 
          if (i == 0) {
             DO_SRC(0);
-         } else if (i == 1) {
+         } else {
             DO_SRC(1);
          }
 #undef DO_SRC
@@ -1011,7 +1011,7 @@ region_alignment_rules(const struct gen_device_info *devinfo,
 
          if (i == 0) {
             DO_SRC(0);
-         } else if (i == 1) {
+         } else {
             DO_SRC(1);
          }
 #undef DO_SRC




More information about the mesa-commit mailing list