Mesa (master): util/disk_cache: Remove unneeded free() on always null string

Eric Engeström eric_engestrom at kemper.freedesktop.org
Thu Dec 7 11:55:31 UTC 2017


Module: Mesa
Branch: master
Commit: b2490a326c28652b85400da0e1bbff108167d140
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=b2490a326c28652b85400da0e1bbff108167d140

Author: Vadym Shovkoplias <vadym.shovkoplias at globallogic.com>
Date:   Mon Dec  4 11:47:33 2017 +0200

util/disk_cache: Remove unneeded free() on always null string

At this point dc_job->cache_item_metadata.keys always equals
NULL, so call to free() is useless

Fixes: b86ecea3446 ("util/disk_cache: write cache item metadata to disk")
Signed-off-by: Vadym Shovkoplias <vadym.shovkoplias at globallogic.com>
Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>

---

 src/util/disk_cache.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/util/disk_cache.c b/src/util/disk_cache.c
index e95406565e..7ebfa8c045 100644
--- a/src/util/disk_cache.c
+++ b/src/util/disk_cache.c
@@ -811,7 +811,6 @@ create_put_job(struct disk_cache *cache, const cache_key key,
    return dc_job;
 
 fail:
-   free(dc_job->cache_item_metadata.keys);
    free(dc_job);
 
    return NULL;




More information about the mesa-commit mailing list