Mesa (master): anv: Disable VK_KHR_16bit_storage
Jason Ekstrand
jekstrand at kemper.freedesktop.org
Sat Dec 9 00:16:09 UTC 2017
Module: Mesa
Branch: master
Commit: 597c194487ab4abe6dd3556faa4f0b8569336245
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=597c194487ab4abe6dd3556faa4f0b8569336245
Author: Jason Ekstrand <jason.ekstrand at intel.com>
Date: Fri Dec 8 15:39:00 2017 -0800
anv: Disable VK_KHR_16bit_storage
The testing for this extension is currently very poor. The CTS tests
only test accessing UBOs and SSBOs at dynamic offsets so none of our
constant-offset paths get triggered at all. Also, there's an assertion
in our handling of nir_intrinsic_load_uniform that offset % 4 == 0 which
is never triggered indicating that nothing every gets loaded from an
offset which is not a dword. Both push constants and the constant
offset pull paths are complex enough, we really don't want to ship
without tests. We'll turn the extension back on once we have decent
tests.
---
src/intel/vulkan/anv_device.c | 4 ++--
src/intel/vulkan/anv_extensions.py | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c
index 81a2ed632b..55b77f9071 100644
--- a/src/intel/vulkan/anv_device.c
+++ b/src/intel/vulkan/anv_device.c
@@ -745,8 +745,8 @@ void anv_GetPhysicalDeviceFeatures2KHR(
VkPhysicalDevice16BitStorageFeaturesKHR *features =
(VkPhysicalDevice16BitStorageFeaturesKHR *)ext;
- features->storageBuffer16BitAccess = pdevice->info.gen >= 8;
- features->uniformAndStorageBuffer16BitAccess = pdevice->info.gen >= 8;
+ features->storageBuffer16BitAccess = false;
+ features->uniformAndStorageBuffer16BitAccess = false;
features->storagePushConstant16 = false;
features->storageInputOutput16 = false;
break;
diff --git a/src/intel/vulkan/anv_extensions.py b/src/intel/vulkan/anv_extensions.py
index 3cdf6c173a..16e5582598 100644
--- a/src/intel/vulkan/anv_extensions.py
+++ b/src/intel/vulkan/anv_extensions.py
@@ -51,7 +51,7 @@ class Extension:
# and dEQP-VK.api.info.device fail due to the duplicated strings.
EXTENSIONS = [
Extension('VK_ANDROID_native_buffer', 5, 'ANDROID'),
- Extension('VK_KHR_16bit_storage', 1, 'device->info.gen >= 8'),
+ Extension('VK_KHR_16bit_storage', 1, False),
Extension('VK_KHR_bind_memory2', 1, True),
Extension('VK_KHR_dedicated_allocation', 1, True),
Extension('VK_KHR_descriptor_update_template', 1, True),
More information about the mesa-commit
mailing list