Mesa (master): glsl: simplify loop in varying_matches::assign_locations()
Brian Paul
brianp at kemper.freedesktop.org
Thu Dec 21 02:19:53 UTC 2017
Module: Mesa
Branch: master
Commit: cd7705de443d34aeddb3a68cc8d6b762a2808261
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=cd7705de443d34aeddb3a68cc8d6b762a2808261
Author: Brian Paul <brianp at vmware.com>
Date: Fri Dec 15 14:27:55 2017 -0700
glsl: simplify loop in varying_matches::assign_locations()
The use of break/continue was kind of weird/confusing.
Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>
---
src/compiler/glsl/link_varyings.cpp | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/compiler/glsl/link_varyings.cpp b/src/compiler/glsl/link_varyings.cpp
index 6d74f9a463..7821b1ec81 100644
--- a/src/compiler/glsl/link_varyings.cpp
+++ b/src/compiler/glsl/link_varyings.cpp
@@ -1834,13 +1834,13 @@ varying_matches::assign_locations(struct gl_shader_program *prog,
const uint64_t slot_mask = ((1ull << slots) - 1) << (*location / 4u);
assert(slots > 0);
- if (reserved_slots & slot_mask) {
- *location = ALIGN(*location + 1, 4);
- slot_end = *location + num_components - 1;
- continue;
+
+ if ((reserved_slots & slot_mask) == 0) {
+ break;
}
- break;
+ *location = ALIGN(*location + 1, 4);
+ slot_end = *location + num_components - 1;
}
if (!var->data.patch && slot_end >= MAX_VARYING * 4u) {
More information about the mesa-commit
mailing list