Mesa (master): intel/fs: Initialize fs_visitor::grf_used on construction.
Francisco Jerez
currojerez at kemper.freedesktop.org
Fri Dec 22 00:22:20 UTC 2017
Module: Mesa
Branch: master
Commit: b3e3cb990125c71c1fd172588852bd92bcfb8904
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b3e3cb990125c71c1fd172588852bd92bcfb8904
Author: Francisco Jerez <currojerez at riseup.net>
Date: Sun Dec 17 00:21:13 2017 -0800
intel/fs: Initialize fs_visitor::grf_used on construction.
This should shut up some Valgrind errors during pre-regalloc
scheduling. The errors were harmless since they could only have led
to the estimation of the bank conflict penalty of an instruction
pre-regalloc, which is inaccurate at that point of the program
compilation, but no less accurate than the intended "return 0"
fall-back path. The scheduling pass is normally re-run after regalloc
with a well-defined grf_used value and accurate bank conflict
information.
Fixes: acf98ff933d "intel/fs: Teach instruction scheduler about GRF bank conflict cycles."
Reported-by: Eero Tamminen <eero.t.tamminen at intel.com>
Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
---
src/intel/compiler/brw_fs_visitor.cpp | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/intel/compiler/brw_fs_visitor.cpp b/src/intel/compiler/brw_fs_visitor.cpp
index 481d9c51e7..7a5f6451f2 100644
--- a/src/intel/compiler/brw_fs_visitor.cpp
+++ b/src/intel/compiler/brw_fs_visitor.cpp
@@ -898,6 +898,7 @@ fs_visitor::init()
this->promoted_constants = 0,
+ this->grf_used = 0;
this->spilled_any_registers = false;
}
More information about the mesa-commit
mailing list