Mesa (master): radv: fix pipeline statistics end query on compute queue

Dave Airlie airlied at kemper.freedesktop.org
Thu Dec 28 09:32:04 UTC 2017


Module: Mesa
Branch: master
Commit: ec1edd0fd29e50fae4aadde152d534a371ba8f6b
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=ec1edd0fd29e50fae4aadde152d534a371ba8f6b

Author: Dave Airlie <airlied at redhat.com>
Date:   Thu Dec 28 16:31:48 2017 +1000

radv: fix pipeline statistics end query on compute queue

It's legal to a pipeline stat query on a compute queue,
but we'd emit the wrong packet here. This should fix it to emit
the correct packet.

Noticed while inspecting the mpv hang.

Fixes: ad61eac250 (radv: factor out eop event writing code. (v2))
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Signed-off-by: Dave Airlie <airlied at redhat.com>

---

 src/amd/vulkan/radv_query.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/amd/vulkan/radv_query.c b/src/amd/vulkan/radv_query.c
index 5dc88af8f8..ace745e4e6 100644
--- a/src/amd/vulkan/radv_query.c
+++ b/src/amd/vulkan/radv_query.c
@@ -1156,7 +1156,7 @@ void radv_CmdEndQuery(
 		si_cs_emit_write_event_eop(cs,
 					   false,
 					   cmd_buffer->device->physical_device->rad_info.chip_class,
-					   false,
+					   radv_cmd_buffer_uses_mec(cmd_buffer),
 					   V_028A90_BOTTOM_OF_PIPE_TS, 0,
 					   1, avail_va, 0, 1);
 		break;




More information about the mesa-commit mailing list