Mesa (master): svga: update SVGA_NEW_ flags for updating sampler state

Brian Paul brianp at kemper.freedesktop.org
Fri Dec 29 05:11:47 UTC 2017


Module: Mesa
Branch: master
Commit: 23f37e98a1a5e8c11dfd55200328701ffb47ebce
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=23f37e98a1a5e8c11dfd55200328701ffb47ebce

Author: Brian Paul <brianp at vmware.com>
Date:   Thu Dec 28 10:07:59 2017 -0700

svga: update SVGA_NEW_ flags for updating sampler state

The SVGA_NEW_FS flag is needed since we now examine the fragment
shader's fs_shadow_compare_units flags.  The SVGA_NEW_TEXTURE_FLAGS
flag is not needed since it's only for pre-VGPU10.

No piglit changes.  This doesn't fix any known issues but it could
pop up somewhere.  Suggested by Charmaine.

Reviewed-by: Charmaine Lee <charmainel at vmware.com>

---

 src/gallium/drivers/svga/svga_state_sampler.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/gallium/drivers/svga/svga_state_sampler.c b/src/gallium/drivers/svga/svga_state_sampler.c
index 11f36e3553..bcc055dc96 100644
--- a/src/gallium/drivers/svga/svga_state_sampler.c
+++ b/src/gallium/drivers/svga/svga_state_sampler.c
@@ -393,6 +393,7 @@ update_samplers(struct svga_context *svga, unsigned dirty )
       for (i = 0; i < count; i++) {
          bool fs_shadow = false;
 
+         /* _NEW_FS */
          if (shader == PIPE_SHADER_FRAGMENT) {
             struct svga_shader_variant *fs = svga->state.hw_draw.fs;
             /* If the fragment shader is doing the shadow comparison
@@ -469,8 +470,8 @@ update_samplers(struct svga_context *svga, unsigned dirty )
 
 struct svga_tracked_state svga_hw_sampler = {
    "texture sampler emit",
-   (SVGA_NEW_SAMPLER |
-    SVGA_NEW_STIPPLE |
-    SVGA_NEW_TEXTURE_FLAGS),
+   (SVGA_NEW_FS |
+    SVGA_NEW_SAMPLER |
+    SVGA_NEW_STIPPLE),
    update_samplers
 };




More information about the mesa-commit mailing list