Mesa (17.0): 39 new commits
Emil Velikov
evelikov at kemper.freedesktop.org
Fri Feb 10 15:48:47 UTC 2017
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=e81e284611fed996b7b5d768af1d5636490c2d7f
Author: Emil Velikov <emil.velikov at collabora.com>
Date: Wed Jan 18 13:54:04 2017 +0000
configure.ac: correctly manage llvm auto-detection
Earlier refactoring commits changed from one, dare I say it, broken
behaviour to another. Namely:
Before, as you explicitly --enable-gallium-llvm your selection was
ignored when llvm-config was not present/detected.
Today, the "auto" heuristics enables gallium llvm regardless if you have
llvm/llvm-config available or not.
Rework the auto-detection to attribute for llvm's presence.
v2: Set enable_gallium_llvm=no when LLVM is not found.
Cc: "17.0" <mesa-stable at lists.freedesktop.org>
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
Reviewed-by: Tobias Droste <tdroste at gmx.de>
Reported-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Tested-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
(cherry picked from commit d4840c0c26315fe4f0ba82e2b0d81cd9f2636f5e)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=edecfda23fdfbbeb802bc4facae5207272414f07
Author: Emil Velikov <emil.velikov at collabora.com>
Date: Wed Jan 18 13:54:03 2017 +0000
configure.ac: disable enable_gallium_llvm in the !x86 case
Already implicitly handled throughout, but keep it clear and disable
gallium-llvm. This change should be a no-op.
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
Reviewed-by: Tobias Droste <tdroste at gmx.de>
(cherry picked from commit ce65cc1f1f648f17d9284e65f1ad69be647de3d3)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d0c7c6a8ccd67eba8f190985dee7ef3dee570bd7
Author: Emil Velikov <emil.velikov at collabora.com>
Date: Wed Jan 18 13:54:02 2017 +0000
configure.ac: set LLVM_{C, CXX, LD}FLAGS only as needed
Earlier refactoring commits started setting the above regardless if LLVM
is used or not. Move them to the respective section to restore the
original functionality.
Since we require the preprocessor flags (includes in particular) for the
header version parsing keep those as-is. They are not used outside of
configure.ac thus should not cause any side-effects.
As-is adding the C/CXXFLAGS can lead to build issues on when
cross-compiling.
Cc: Ilia Mirkin <imirkin at alum.mit.edu>
Cc: Tomasz Figa <tfiga at chromium.org>
Cc: "17.0" <mesa-stable at lists.freedesktop.org>
Reported-by: Ilia Mirkin <imirkin at alum.mit.edu>
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
Reviewed-by: Tobias Droste <tdroste at gmx.de>
(cherry picked from commit 4d8bb9cf8c8e8bd3185461760ca89e6021c0b8e0)
Conflicts:
configure.ac
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=619b102ecba50c130b40edbb2f0c75cc9b6acccb
Author: Tobias Droste <tdroste at gmx.de>
Date: Tue Feb 7 19:53:32 2017 +0000
configure.ac: Only define HAVE_LLVM if LLVM is used
Make sure that HAVE_LLVM compiler define is only set if LLVM is
actually used.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99010
Cc: "17.0" <mesa-stable at lists.freedesktop.org>
Signed-off-by: Tobias Droste <tdroste at gmx.de>
v2 [Emil] fold within the existing conditional
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
(cherry picked from commit 143c566a81fa7425df64ca83b8131e016af1d660)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b90405d56569abd9d6845040de4e948031a0e366
Author: Tobias Droste <tdroste at gmx.de>
Date: Sat Jan 28 14:56:57 2017 +0100
configure.ac: Rework MESA_LLVM and LLVM detection
Set FOUND_LLVM only when LLVM is present (checking for exact version/etc
is deferred) and use enable-gallium-llvm to indicate the global LLVM
status.
Renaming the latter is not appropriate for stable patches, so we'll
address it with a later commit.
Loosely based on work by Tobias.
v2: Check FOUND_LLVM if enable_gallium_llvm is set.
Cc: Dave Airlie <airlied at redhat.com>
Cc: "17.0" <mesa-stable at lists.freedesktop.org>
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
Reviewed-by: Tobias Droste <tdroste at gmx.de>
(cherry picked from commit 04377cbdcf19a112c04035d622c40d722cc238d7)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d6e8489069bb335bf8cb776bb23da9716bbe4a5e
Author: Emil Velikov <emil.velikov at collabora.com>
Date: Tue Feb 7 21:59:14 2017 +0000
configure.ac: move enable-gallium-llvm dependency with-gallium-drivers
... to where it's applicable.
Since we effectively made --enable-gallium-llvm mean --enable-llvm with
earlier commits, we need to move the requirement to guard the compnents
added for the LLVM draw.
Otherwise we'll error (as below) when building RADV w/o gallium drivers.
configure: error: --enable-gallium-llvm is required when building radv
v2: Don't remove but move the dependency (Tobias).
Cc: Dave Airlie <airlied at redhat.com>
Cc: "17.0" <mesa-stable at lists.freedesktop.org>
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
Reviewed-by: Tobias Droste <tdroste at gmx.de>
(cherry picked from commit 5869a7db75a144ae898dafe9d9b7cb9d6ae29e12)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=fbc28af6e51daa3c37a361a547ffcf81137cc207
Author: Emil Velikov <emil.velikov at collabora.com>
Date: Tue Feb 7 16:24:44 2017 +0000
configure.ac: Mandate --enable-gallium-llvm when checking LLVM version
With this change we effectively require --enable-gallium-llvm when
building RADV. This should be perfectly safe since the gallium radeonsi
driver already explicitly requires it.
The "gallium" part in --enable-gallium-llvm is about to be removed soon
(not in stable), but until then make sure that things can build.
To reflect the requirement (as opposed to check previously) we rename
llvm_check_version_for to llvm_require_version
Cc: Dave Airlie <airlied at redhat.com>
Cc: "17.0" <mesa-stable at lists.freedesktop.org>
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
Reviewed-by: Tobias Droste <tdroste at gmx.de>
(cherry picked from commit a66ffcd736459753a2c3ab73b6c47c66f621fd79)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=8ae5b0b5677bf64920f002bcd4b8ed0350e23cec
Author: Emil Velikov <emil.velikov at collabora.com>
Date: Tue Feb 7 16:13:07 2017 +0000
configure.ac: Rename the gallium_require_llvm helper
Drop the gallium prefix since we're about it use it throughout the
configure.
Note we do want to check for enable_gallium_llvm check since (as
explicitly requested) the toggle should mean --enable-llvm. Latter of
which to be resolved with later patches.
Cc: Dave Airlie <airlied at redhat.com>
Cc: "17.0" <mesa-stable at lists.freedesktop.org>
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
Reviewed-by: Tobias Droste <tdroste at gmx.de>
(cherry picked from commit 514a4944152d3d1a4ac54495388d302e7b7fe0b3)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=726596300708c83cdace501a72b5765f3d95510d
Author: Tobias Droste <tdroste at gmx.de>
Date: Sat Jan 28 14:57:00 2017 +0100
configure.ac: Don't check LLVM version in require_llvm
This is actually not needed because the version is checked later.
Around line 2380
if test "x$enable_gallium_llvm" == "xyes"; then
llvm_check_version_for $LLVM_REQUIRED_GALLIUM "gallium"
llvm_add_default_components "gallium"
fi
Cc: "17.0" <mesa-stable at lists.freedesktop.org>
Cc: Tobias Droste <tdroste at gmx.de>
Signed-off-by: Tobias Droste <tdroste at gmx.de>
Reviewed-by: Emil Velikov <emil.velikov at collabora.com> (v1)
v2: [Emil Velikov: rebase/respin series order]
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
(cherry picked from commit f64d4d82bd877418a553827cf0ffb9d5742127a8)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=ba43238abf411fb4d947007b9c59ce2da4ad735a
Author: Emil Velikov <emil.velikov at collabora.com>
Date: Tue Feb 7 20:48:12 2017 +0000
configure.ac: move AC_ARG_ENABLE([gallium-llvm] hunk further up
With next commits we'll require --enable-gallium-llvm (en route to a
greater good later on) for RADV. The latter is required to ensure that
as otherwise we'll fail to build.
Cc: Dave Airlie <airlied at redhat.com>
Cc: "17.0" <mesa-stable at lists.freedesktop.org>
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
Reviewed-by: Tobias Droste <tdroste at gmx.de>
(cherry picked from commit 38abcdba8a59e88a91d598951323b977fb3fa1ad)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=7e6b4a2dd75a4082cb0c82a4bf240a6d2059a410
Author: Nanley Chery <nanley.g.chery at intel.com>
Date: Sat Jan 21 13:35:50 2017 -0800
anv/blorp: Disable resolves for transparent black clears
Signed-off-by: Nanley Chery <nanley.g.chery at intel.com>
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
(cherry picked from commit 84dbf683781241038d847b9db81f153ab59e27f6)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=72156aa1007089daafef5662a00e02654576ab2c
Author: Marek Olšák <marek.olsak at amd.com>
Date: Thu Feb 9 03:14:22 2017 +0100
gallium/radeon: fix performance of buffer readbacks
We want cached GTT for all non-persistent read mappings.
Set level = 0 on purpose.
Use dma_copy, because resource_copy_region causes a failure in the PBO
read of piglit/getteximage-luminance.
If Rocket League used the READ flag, it should get cached GTT.
v2: mask out UNSYNCHRONIZED
Cc: 13.0 17.0 <mesa-stable at lists.freedesktop.org>
Reviewed-by: Nicolai Hähnle <nicolai.haehnle at amd.com>
(cherry picked from commit d86099df0af7c22c8acfd48b38ad446d9c8df6bd)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=32d0dc50a07e88aef69754820a42b13054ccfa11
Author: Marc-André Lureau <marcandre.lureau at redhat.com>
Date: Thu Feb 9 18:41:11 2017 +0400
tgsi-dump: dump label if instruction has one
The instruction has an associated label when Instruction.Label == 1,
as can be seen in ureg_emit_label() or tgsi_build_full_instruction().
This fixes dump generating extra :0 labels on conditionals, and virgl
parsing more than the expected tokens and eventually reaching "Illegal
command buffer" (when parsing more than a safety margin of 10 we
currently have).
Signed-off-by: Marc-André Lureau <marcandre.lureau at redhat.com>
Cc: "13.0 17.0" <mesa-stable at lists.freedesktop.org>
Signed-off-by: Dave Airlie <airlied at redhat.com>
(cherry picked from commit dc2d9b8da14b97376cca9c87e2408763b11bdaa7)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=8ca2e38abbb13942705c64a213adda5683c8dec8
Author: Ilia Mirkin <imirkin at alum.mit.edu>
Date: Thu Feb 9 15:35:51 2017 -0500
nvc0/ir: fix ubo max clamp, reset file index
We just increased the max UBO, so we should also increase the clamp that
we do for robustness. Similarly, as we're including the fileIndex in the
new indirect value, we should reset fileIndex to 0 so that it is not
added in a second time.
Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Cc: mesa-stable at lists.freedesktop.org
(cherry picked from commit c95f821cb4286f8163bfdf341be2b0940011585a)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=40281fcaf9e97e457701bebd622e7c9cc69d08b4
Author: Ilia Mirkin <imirkin at alum.mit.edu>
Date: Wed Jan 25 23:48:23 2017 -0500
nvc0/ir: fix robustness guarantees for constbuf loads on kepler+ compute
Kepler and up unfortunately only support up to 8 constbufs. We work
around this by loading from constbufs as if they were storage buffers.
However we were not consistently applying limits to loads from these
buffers. Make sure to do the same thing we do for storage buffers.
Fixes GL45-CTS.robust_buffer_access_behavior.uniform_buffer
Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Cc: mesa-stable at lists.freedesktop.org
(cherry picked from commit 1acdd62847cf0da8a8e9c7915d698208d73a5be8)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=73b1570dc1959d7efe2512db956a98925a90fddb
Author: Ilia Mirkin <imirkin at alum.mit.edu>
Date: Wed Jan 25 23:06:22 2017 -0500
nvc0: increase number of ubo binding points
Apparently GL 4.5 requires 14 of these (there's a "*" in the spec, but
it's unclear what it refers to). We need to expose an extra binding
point for the "program parameters", which means this must be 15. Remove
the last vestige of the "use c14 for immediates" idea.
Fixes GL45-CTS.shading_language_420pack.binding_uniform_block_array
Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Cc: mesa-stable at lists.freedesktop.org
(cherry picked from commit 59ca352fc573a37f9f70c1f6217e85dd3e31d38e)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=06128bdc212778f0471f65a421cf2a1df3616ff8
Author: Marc Di Luzio <mdiluzio at feralinteractive.com>
Date: Mon Feb 6 09:07:30 2017 +0000
glsl: correct compute shader checks for memoryBarrier functions
As per the spec -
"The functions memoryBarrierShared() and groupMemoryBarrier() are
available only in compute shaders; the other functions are available
in all shader types."
Conform to this by adding another delegate to check for compute
shader support instead of only whether the current stage is compute
This allows some fragment shaders in Dirt Rally to compile
Cc: "17.0" <mesa-stable at lists.freedesktop.org>
Reviewed-by: Anuj Phogat <anuj.phogat at gmail.com>
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
(cherry picked from commit 21efe2528cd88cb09ba9f69222f69a8ee47611c9)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=05abd64caef4b90ae2f70a2e8d35c2dd80cd035d
Author: Kenneth Graunke <kenneth at whitecape.org>
Date: Sat Jan 21 03:54:46 2017 -0800
Revert "i965: Disable guardband clipping in the smaller-than-viewport case."
This reverts commit 0bac2551e40410e2251daf4fd9faf69310ab34ce.
Now that we position the guardband correctly (applying translations
in addition to scaling) and made it as large (or larger) than the
render target, this shouldn't be necessary.
Now we leave guardband clipping enabled 100% of the time, like the
Windows driver does.
Fixes GL45-CTS.gtf21.GL2FixedTests.clip.clip. It tries to draw a
16384x64 rectangle, and it appears that some kind of numerical
imprecisions in the clipper result in some edge pixels going missing.
The Windows driver passes this test because of guardband clipping.
Cc: "17.0" <mesa-stable at lists.freedesktop.org>
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
(cherry picked from commit ce8a63de6dffd4a7bc704b63bdd48a63798a438e)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=09468226b4e689ee6ba03534cda4875958f9d8d3
Author: Kenneth Graunke <kenneth at whitecape.org>
Date: Wed Jan 11 21:38:52 2017 -0800
i965: Always scissor on Gen6-7.5 instead of disabling guardband.
Previously we disabled the guardband when the viewport was smaller than
the framebuffer on Gen6-7.5, to prevent portions of primitives from
being draw outside of the viewport. On Gen8+, we relied on the viewport
extents test to effectively scissor this away for us.
We can simply always enable scissoring instead. We already include the
viewport in the scissor rectangle, so this will effectively do the
viewport extents test for us. (The only difference is that the scissor
rectangle doesn't support sub-pixel values. I think that's okay.)
Given that the viewport extents test is essentially a second scissor,
and is enabled for basically all 3D drawing on Gen8+, it stands to
reason that scissoring is cheap. Enabling the guardband reduces the
cost of clipping, which is expensive.
The Windows driver appears to never disable guardband clipping, and
appears to use scissoring in this case. I don't know if they leave
it on universally though.
This fixes misrendering in Blender, where the "floor plane" grid lines
started rendering at wrong angles after I disabled XY clipping of line
primitives. Enabling the guardband seems to solve the issue.
Cc: "17.0" <mesa-stable at lists.freedesktop.org>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99339
Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
(cherry picked from commit ece0e535a44c228dd994861592deb155c14740d8)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d44a881ba67b175871b3f89d3899a586666460fb
Author: Jason Ekstrand <jason at jlekstrand.net>
Date: Sat Jan 21 03:50:42 2017 -0800
i965: Use a better guardband calculation.
(Patch co-authored by Jason and Ken.)
We scaled the guardband based on the viewport size, but failed to
take into account the translation portion of the viewport transform.
This meant the guardband was always centered around the origin.
We want it to be centered around the screen-space drawing area,
which is the intersection of the viewport and the render target.
At best, getting this wrong would reduce the guardband's effectiveness
in some cases. At worst, it might break things - objects outside of the
guardband are trivially rejected, so getting the guardband in the wrong
place and leaving guardband clipping enabled could cause problems.
v2: drop clamping of positive maximums.
Cc: "17.0" <mesa-stable at lists.freedesktop.org>
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
(cherry picked from commit f3c068c5c89c8c3dce257ecc2b640f375d3f4836)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=726c32790eddcad9c19e4c1d1c740ab74424dad7
Author: Kenneth Graunke <kenneth at whitecape.org>
Date: Sat Jan 21 14:10:15 2017 -0800
i965: Combine the Gen6 SF and Clip viewport atoms.
The next patch will make the guardband calculation dependent on the
transformation matrix. Instead of computing it in both atoms, just
combine them into a single atom.
Cc: "17.0" <mesa-stable at lists.freedesktop.org>
Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
Reviewed-by: Topi Pohjolainen <topi.pohjolainen at intel.com>
(cherry picked from commit 89ad7f1be6a607b33ffb388516b5d0547b491c33)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=dc398d94f07879ddde0202353df7cfc96c1c17dd
Author: Dave Airlie <airlied at redhat.com>
Date: Tue Feb 7 10:31:11 2017 +1000
radv: pass FMASK alignment to application
As was done for dcc and cmask.
Cc: "17.0" <mesa-stable at lists.freedesktop.org>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Signed-off-by: Dave Airlie <airlied at redhat.com>
(cherry picked from commit 90ac2285f0900972d2a3e7a034b51ee4de374ffb)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d42419445552c92913e9b54e9cd0649058ff2aea
Author: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Date: Tue Feb 7 00:45:11 2017 +0100
radv: Pass DCC alignment to application.
Signed-off-by: Bas Nieuwenhuizen <basni at google.com>
Cc: "17.0" <mesa-stable at lists.freedesktop.org>
Reviewed-by: Dave Airlie <airlied at redhat.com>
Reviewed-by: Andres Rodriguez <andresx7 at gmail.com>
(cherry picked from commit 47ca0f537dfbc03f0eb0cb12fdee06dbe664fbc7)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=27b6f7413cf64cec0c2a2a8af5a1dc487019de51
Author: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Date: Tue Feb 7 00:24:16 2017 +0100
radv: Pass CMASK alignment to application.
CMASK alignment can be greater than image data alignment, so pass
it to the app so that it knows what alignment to backing memory
should have.
Signed-off-by: Bas Nieuwenhuizen <basni at google.com>
Cc: <mesa-stable at lists.freedesktop.org>
Reviewed-by: Dave Airlie <airlied at redhat.com>
(cherry picked from commit eb01b20cc41e9501062eb25034069e484f8b1899)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=1e868de4500a46abde745a517ead42afd3a904ca
Author: Dave Airlie <airlied at redhat.com>
Date: Mon Feb 6 02:40:45 2017 +0000
radv/ac: avoid the fmask path when doing txs.
This fixes the vulkan samples deferredmultisampling test.
Cc: "17.0" <mesa-stable at lists.freedesktop.org>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Signed-off-by: Dave Airlie <airlied at redhat.com>
(cherry picked from commit a864ef7f4824a8319b74d4cf1c82e2dd25672ff1)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=be48168be94f669a050cbe76bd2ed05566cf4b96
Author: Bruce Cherniak <bruce.cherniak at intel.com>
Date: Thu Feb 2 14:15:08 2017 -0600
swr: [rasterizer core] Remove dead code Clipper::ClipScalar()
Clipper::ClipScalar() is dead code and should be removed. It is causing
an error with gcc-7 because it references a now defunct member.
v2: includes bugzilla reference, same code change
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99633
CC: "13.0 17.0" <mesa-stable at lists.freedesktop.org>
Tested-by: Vinson Lee <vlee at freedesktop.org>
Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>
Reviewed-by: Tim Rowley <timothy.o.rowley at intel.com>
(cherry picked from commit bf29495dcdb290c8b15cacd2001603b8ae5d36c8)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=cdc5bb81ff40e4df59dbbaf5896d74681c676f0a
Author: Nicolai Hähnle <nicolai.haehnle at amd.com>
Date: Fri Jan 27 11:55:14 2017 +0100
dri/common: clear the loaderPrivate pointer in driDestroyDrawable
The GLX specification says about glXDestroyPixmap:
"The storage for the GLX pixmap will be freed when it is not current
to any client."
We're not really following this language to the letter: some of the storage
is freed immediately (in particular, the dri3_drawable, which contains both
GLXDRIdrawable and loader_dri3_drawable). So we NULL out the pointers to
that freed storage; the previous patches added the corresponding NULL-pointer
checks.
This fixes memory corruption in piglit
./bin/glx-visuals-depth/stencil -pixmap -auto
Cc: 17.0 <mesa-stable at lists.freedesktop.org>
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
(cherry picked from commit 7be0e602ed82d25b9f0db77748618c663d9cbfe7)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=e4bb5be7b27cd3a5c8b6d98a1e1b5f9a55815103
Author: Nicolai Hähnle <nicolai.haehnle at amd.com>
Date: Thu Feb 2 18:06:27 2017 +0100
glx: guard swap-interval functions against destroyed drawables
The GLX specification says about glXDestroyPixmap:
"The storage for the GLX pixmap will be freed when it is not current
to any client."
So arguably, functions like glXSwapIntervalMESA can be called after
glXDestroyPixmap has been called for the currently bound GLXPixmap.
In that case, the GLXDRIDrawable no longer exists, and so we just skip
those calls.
Cc: 17.0 <mesa-stable at lists.freedesktop.org>
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
(cherry picked from commit f446f3fb33528eebe9b120340fca3ac5c5ba518d)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=48d5cf36a1cfd548e6a98d96828273f035066b5b
Author: Nicolai Hähnle <nicolai.haehnle at amd.com>
Date: Thu Feb 2 18:01:06 2017 +0100
glx/dri3: guard in_current_context against a disappeared drawable
Cc: 17.0 <mesa-stable at lists.freedesktop.org>
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
(cherry picked from commit 21ec35566be2c1aca07083a67f462618ae15fa86)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b3bc9b4b526157356931d76ecb1b389316514212
Author: Nicolai Hähnle <nicolai.haehnle at amd.com>
Date: Fri Jan 27 11:58:41 2017 +0100
glx/dri3: handle NULL pointers in loader-to-DRI3 drawable conversion
With a subsequent patch, we might see NULL loaderPrivates, e.g. when
a DRIdrawable is flushed whose corresponding GLXDRIdrawable was destroyed.
This resulted in a crash, since the loader vs. DRI3 drawable structures
have a non-zero offset.
Fixes glx-visuals-{depth,stencil} -pixmap
Cc: 17.0 <mesa-stable at lists.freedesktop.org>
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
(cherry picked from commit 40c304fc065259c07c0f4f7a35efedd205e4f250)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=241e0b7068c0ae8e5e3480b9f6846a5749184626
Author: Dave Airlie <airlied at redhat.com>
Date: Fri Feb 3 03:26:13 2017 +0000
radv: fix shared memory load/stores.
If we have an indirect index here we need to scale it by attribute slots
e.g. is this is vec2[256] then we get an indir_index in the 0.255 range
but the vec2 are aligned inside vec4 slots. So scale the indir index,
then extract the channels.
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Cc: "17.0" <mesa-stable at lists.freedesktop.org>
Signed-off-by: Dave Airlie <airlied at redhat.com>
(cherry picked from commit 106a51440d018031b94c91758eecc7424a3bb5ee)
[Emil Velikov: resolve trivial conflicts]
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
Conflicts:
src/amd/common/ac_nir_to_llvm.c
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=e789af4a9f10e56f908e3c55c6d764d62c7838de
Author: Dave Airlie <airlied at redhat.com>
Date: Fri Feb 3 01:46:24 2017 +0000
radv/ac: correctly size shared memory usage.
We count the number of slots used, but slots are vec4 sized,
so we have to scale by 16 not 4.
Reviewed-by: Edward O'Callaghan <funfunctor at folklore1984.net>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Cc: "17.0" <mesa-stable at lists.freedesktop.org>
Signed-off-by: Dave Airlie <airlied at redhat.com>
(cherry picked from commit a1a8aef4c9dbdf254036adada95f0d6e394c5d6a)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f02f17f133d7f979215d8bf6fc33e2c97f17457b
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date: Thu Feb 2 18:40:18 2017 +0100
winsys/amdgpu: avoid potential segfault in amdgpu_bo_map()
cs can be NULL when it comes from r600_buffer_map_sync_with_rings()
to avoid doing the same checks. It was checked for write mappings
but not for read mappings.
Cc: "17.0" <mesa-stable at lists.freedesktop.org>
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
(cherry picked from commit af303abcdbeac3b90fb760de19bed56cc40cfff4)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d4f1ed62158e69a028e84d9ebc1b642be5bf0e07
Author: Ilia Mirkin <imirkin at alum.mit.edu>
Date: Wed Jan 25 22:31:58 2017 -0500
st/mesa: MAX_VARYING is the max supported number of patch varyings, not min
This fixes
GL45-CTS.tessellation_shader.tessellation_shader_tessellation.max_in_out_attributes
on nouveau. We only support 30 patch varyings (as 2 vec4 slots end up
being used for tess level settings), but were getting 32 exposed.
Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Cc: "13.0 17.0" <mesa-stable at lists.freedesktop.org>
(cherry picked from commit 7d3f9ed71c71637a91ecf15f50dbe7578a65d57e)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d936b576d6dae6f7a91d8cb7e33fd5cbb537108f
Author: Ilia Mirkin <imirkin at alum.mit.edu>
Date: Wed Feb 1 16:11:41 2017 -0500
vbo: process buffer binding state changes on draw when recording
The VBO module keeps track of any vbo buffers. It updates this list when
receiving an InvalidateState call, however this never happens when
recording draws right now. Make sure that we do all the usual state
updates when recording draws so that the VBO list may be kept up to
date.
Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99631
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Reviewed-by: Brian Paul <brianp at vmware.com>
Cc: "13.0 17.0" <mesa-stable at lists.freedesktop.org>
(cherry picked from commit e73f87fcbdcb12b0b8d28c4ca3444bfb7669bca5)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=539afe4e33f7c297545365cd97834ec031e4ca05
Author: Marek Olšák <marek.olsak at amd.com>
Date: Thu Feb 2 19:42:22 2017 +0100
Revert "radeonsi: decrease the number of texture slots to 24"
This reverts commit bdd860e3076655519d45bd66936ef7be9b7dda63.
Requested by a game developer.
Cc: 17.0 <mesa-stable at lists.freedesktop.org>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Nicolai Hähnle <nicolai.haehnle at amd.com>
(cherry picked from commit dfe111368d11aaffae7f8738c858c335cdec1e9d)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=19f029ce6307dc2220411242e2d8b7217851043f
Author: Nanley Chery <nanley.g.chery at intel.com>
Date: Tue Jan 31 19:01:18 2017 -0800
anv/pass: Store the depth-stencil attachment's last subpass index
Commit 968ffd6c868af7226e8f889573eef709888151cb stored the last subpass
index of all the attachments but that of the depth-stencil attachment.
This could cause depth buffers used in multiple subpasses not to be in
the requested final layout. Fix this error.
Cc: "17.0" <mesa-stable at lists.freedesktop.org>
Reviewed-by: Samuel Iglesias Gonsálvez <siglesias at igalia.com>
Signed-off-by: Nanley Chery <nanley.g.chery at intel.com>
(cherry picked from commit 043d92fef9315dcc303f36d472eb38b5511bb2cd)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=ebbca2f7bbf66ffc62c9e8193ed35acaf71ffb31
Author: Matt Turner <mattst88 at gmail.com>
Date: Mon Jan 23 16:48:01 2017 -0800
vulkan: Don't install vk_platform.h or vulkan.h.
These files belong to the vulkan loader.
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
(cherry picked from commit 045f38a50759bb225cb179703bc7050f6de752b1)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=40fc6e7c2d81b34b9570383d7d681693ce87e390
Author: Tapani Pälli <tapani.palli at intel.com>
Date: Thu Jan 19 09:10:34 2017 +0200
android: correct typo in build
Fixes: 63c58dfc653c499aab5b8d0ea07f1dc1af88c856
Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
(cherry picked from commit 4148881513b1cba6d4737803cc903546e59d5b91)
More information about the mesa-commit
mailing list