Mesa (master): gallivm: (trivial) fix typo bug with small AoS format unpacking

Roland Scheidegger sroland at kemper.freedesktop.org
Thu Jan 5 23:47:58 UTC 2017


Module: Mesa
Branch: master
Commit: caf18a8434bd3a51fcfe557a441e60fae78e7924
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=caf18a8434bd3a51fcfe557a441e60fae78e7924

Author: Roland Scheidegger <sroland at vmware.com>
Date:   Fri Jan  6 00:46:15 2017 +0100

gallivm: (trivial) fix typo bug with small AoS format unpacking

Fix typo using wrong (uninitialized) build context introduced by
4634cb5921b985f04f2daf00cda2d28036143bd3. (This only affects very rare
small packed formats which have a PIPE_SWIZZLE_0 channel, such as
r4a4, which is never used by mesa/st. Nevertheless it broke lp_test_format.)

---

 src/gallium/auxiliary/gallivm/lp_bld_format_aos.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/auxiliary/gallivm/lp_bld_format_aos.c b/src/gallium/auxiliary/gallivm/lp_bld_format_aos.c
index 11d1118..2f72385 100644
--- a/src/gallium/auxiliary/gallivm/lp_bld_format_aos.c
+++ b/src/gallium/auxiliary/gallivm/lp_bld_format_aos.c
@@ -542,7 +542,7 @@ lp_build_fetch_rgba_aos(struct gallivm_state *gallivm,
       conv_type = lp_type_int_vec(type.width*4, type.width * type.length);
       dst_vec_type = lp_build_vec_type(gallivm, type);
       conv_vec_type = lp_build_vec_type(gallivm, conv_type);
-      lp_build_context_init(&bld, gallivm, conv_type);
+      lp_build_context_init(&bld_conv, gallivm, conv_type);
 
       packed = lp_build_gather(gallivm, type.length/4,
                                format_desc->block.bits, fetch_type,




More information about the mesa-commit mailing list