Mesa (master): configure: error out when building static XOR shared

Emil Velikov evelikov at kemper.freedesktop.org
Wed Jan 18 16:03:37 UTC 2017


Module: Mesa
Branch: master
Commit: 687cf37bbe724d3bd910d5d8c55eb27e1b196f65
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=687cf37bbe724d3bd910d5d8c55eb27e1b196f65

Author: Emil Velikov <emil.velikov at collabora.com>
Date:   Wed Dec  7 13:25:01 2016 +0000

configure: error out when building static XOR shared

Current code warns out in such cases and falls-back to either static or
shared. That can be easily missed amongst the volume produced by our
configure script.

Replace the warning with an error such that one gets direct feedback
when they're doing something wrong.

Signed-off-by: Emil Velikov <emil.velikov at collabora.com>

---

 configure.ac | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/configure.ac b/configure.ac
index 6771aa6..33f1c42 100644
--- a/configure.ac
+++ b/configure.ac
@@ -468,12 +468,10 @@ dnl explicitly requested. If both disabled, set to static since shared
 dnl was explicitly requested.
 case "x$enable_static$enable_shared" in
 xyesyes)
-    AC_MSG_WARN([Cannot build static and shared libraries, disabling shared])
-    enable_shared=no
+    AC_MSG_ERROR([Cannot enable both static and shared. Building using --enable-shared is strongly recommended])
     ;;
 xnono)
-    AC_MSG_WARN([Cannot disable both static and shared libraries, enabling shared])
-    enable_shared=yes
+    AC_MSG_ERROR([Cannot disable both static and shared. Building using --enable-shared is strongly recommended])
     ;;
 esac
 




More information about the mesa-commit mailing list