Mesa (master): swr: don't forget to link AVX/AVX2 against pthreads
Emil Velikov
evelikov at kemper.freedesktop.org
Mon Jul 24 10:02:16 UTC 2017
Module: Mesa
Branch: master
Commit: 33d397ada50a1d1f485205e847003dc48146ec19
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=33d397ada50a1d1f485205e847003dc48146ec19
Author: Emil Velikov <emil.velikov at collabora.com>
Date: Fri Jul 21 16:44:14 2017 +0100
swr: don't forget to link AVX/AVX2 against pthreads
Seems like the backends have been using pthreads since day one, yet
we've been missing the link.
With later commit we'll fix a typo, hence the libraries will be build
with -Wl,no-undefined, aka failing the build on unresolved symbols.
v2: Split from a larger patch.
Cc: mesa-stable at lists.freedesktop.org
Cc: Bruce Cherniak <bruce.cherniak at intel.com>
Cc: Tim Rowley <timothy.o.rowley at intel.com>
Cc: Laurent Carlier <lordheavym at gmail.com>
Fixes: c6e67f5a9373e916a8d2 "gallium/swr: add OpenSWR rasterizer"
Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
---
src/gallium/drivers/swr/Makefile.am | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/src/gallium/drivers/swr/Makefile.am b/src/gallium/drivers/swr/Makefile.am
index 6495021457..02010727d9 100644
--- a/src/gallium/drivers/swr/Makefile.am
+++ b/src/gallium/drivers/swr/Makefile.am
@@ -246,6 +246,7 @@ if HAVE_SWR_AVX
lib_LTLIBRARIES += libswrAVX.la
libswrAVX_la_CXXFLAGS = \
+ $(PTHREAD_CFLAGS) \
$(SWR_AVX_CXXFLAGS) \
-DKNOB_ARCH=KNOB_ARCH_AVX \
$(COMMON_CXXFLAGS)
@@ -253,6 +254,9 @@ libswrAVX_la_CXXFLAGS = \
libswrAVX_la_SOURCES = \
$(COMMON_SOURCES)
+libswrAVX_la_LIBADD = \
+ $(PTHREAD_LIBS)
+
libswrAVX_la_LDFLAGS = \
$(COMMON_LDFLAGS)
endif
@@ -260,6 +264,7 @@ endif
if HAVE_SWR_AVX2
lib_LTLIBRARIES += libswrAVX2.la
libswrAVX2_la_CXXFLAGS = \
+ $(PTHREAD_CFLAGS) \
$(SWR_AVX2_CXXFLAGS) \
-DKNOB_ARCH=KNOB_ARCH_AVX2 \
$(COMMON_CXXFLAGS)
@@ -267,6 +272,9 @@ libswrAVX2_la_CXXFLAGS = \
libswrAVX2_la_SOURCES = \
$(COMMON_SOURCES)
+libswrAVX2_la_LIBADD = \
+ $(PTHREAD_LIBS)
+
libswrAVX2_la_LDFLAGS = \
$(COMMON_LDFLAGS)
endif
More information about the mesa-commit
mailing list