Mesa (master): i965: Use {} to initialize GENX_* structs.
Rafael Antognolli
rantogno at kemper.freedesktop.org
Mon Jul 24 23:09:47 UTC 2017
Module: Mesa
Branch: master
Commit: 8c47ccb13a198f4d38c772df1de457de34dde23e
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=8c47ccb13a198f4d38c772df1de457de34dde23e
Author: Rafael Antognolli <rafael.antognolli at intel.com>
Date: Wed Jul 12 16:36:03 2017 -0700
i965: Use {} to initialize GENX_* structs.
gen4 have commands which start with KernelStartPointer, which is a
struct, so if we initialize it struct = { 0 }, we get warnings on some
compilers:
"GCC (pre 4.9?) can throw a Wmissing-braces on[1] while clang
-Wmissing-field-initializers [2]." - Emil
[1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53119
[2] https://bugs.llvm.org/show_bug.cgi?id=21689
This change works around that and will silence such warnings. It is both
a GCC and a clang extension.
v2:
- Use {} instead of memset macro (Matt)
Signed-off-by: Rafael Antognolli <rafael.antognolli at intel.com>
Cc: Jason Ekstrand <jason at jlekstrand.net>
Cc: Matt Turner <mattst88 at gmail.com>
Cc: Emil Velikov <emil.l.velikov at gmail.com>
Reviewed-by: Francisco Jerez <currojerez at riseup.net>
---
src/mesa/drivers/dri/i965/genX_state_upload.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c b/src/mesa/drivers/dri/i965/genX_state_upload.c
index ef04603df8..dacccf78f5 100644
--- a/src/mesa/drivers/dri/i965/genX_state_upload.c
+++ b/src/mesa/drivers/dri/i965/genX_state_upload.c
@@ -206,7 +206,7 @@ KSP(struct brw_context *brw, uint32_t offset)
})
#define brw_state_emit(brw, cmd, align, offset, name) \
- for (struct cmd name = { 0, }, \
+ for (struct cmd name = {}, \
*_dst = brw_state_batch(brw, _brw_cmd_length(cmd) * 4, \
align, offset); \
__builtin_expect(_dst != NULL, 1); \
More information about the mesa-commit
mailing list