Mesa (master): i965: Shut up Coverity warning about HiZ buffers.
Kenneth Graunke
kwg at kemper.freedesktop.org
Wed Jul 26 05:20:17 UTC 2017
Module: Mesa
Branch: master
Commit: 445367242a221d8e7d0f8ce31a9df75e86f8af0e
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=445367242a221d8e7d0f8ce31a9df75e86f8af0e
Author: Kenneth Graunke <kenneth at whitecape.org>
Date: Tue Jul 25 10:27:03 2017 -0700
i965: Shut up Coverity warning about HiZ buffers.
Here the AUX_USAGE_* mode indicates that we have HiZ, so we will have
a HiZ buffer. But Coverity doesn't know that, so it thinks it might
be NULL because we checked hiz_buf != NULL earlier.
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
---
src/mesa/drivers/dri/i965/brw_blorp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/mesa/drivers/dri/i965/brw_blorp.c b/src/mesa/drivers/dri/i965/brw_blorp.c
index a0f37780ef..b2987ca4fa 100644
--- a/src/mesa/drivers/dri/i965/brw_blorp.c
+++ b/src/mesa/drivers/dri/i965/brw_blorp.c
@@ -184,6 +184,7 @@ blorp_surf_for_miptree(struct brw_context *brw,
surf->aux_addr.buffer = mt->mcs_buf->bo;
surf->aux_addr.offset = mt->mcs_buf->offset;
} else {
+ assert(mt->hiz_buf);
assert(surf->aux_usage == ISL_AUX_USAGE_HIZ);
surf->aux_addr.buffer = mt->hiz_buf->bo;
More information about the mesa-commit
mailing list