Mesa (17.2): 32 new commits
Emil Velikov
evelikov at kemper.freedesktop.org
Mon Jul 31 10:41:40 UTC 2017
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=58fe86a6d69c1169cff0c0b3084c906dbda7e266
Author: Emil Velikov <emil.velikov at collabora.com>
Date: Mon Jul 31 10:52:13 2017 +0100
Update version to 17.2.0-rc2
Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d466a7053247fb76f23d7cdaf1745aa9c9bd7fd5
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date: Thu Jul 27 17:12:09 2017 +0200
st/glsl_to_tgsi: fix getting the image type for array of structs
Since array splitting for AoA is disabled, we have to retrieve
the type of the first non-array type when an array of images is
declared inside a structure. Otherwise, it will hit an assert
in glsl_type::sampler_index() because it expects either a sampler
or an image type.
This fixes a regression in the following piglit test:
arb_bindless_texture/compiler/images/arrays-of-struct.frag
Fixes: 57165f2ef8 ("glsl: disable array splitting for AoA")
Cc: 17.2 <mesa-stable at lists.freedesktop.org>
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
(cherry picked from commit f99e9335e2ca46ec8ead00b63e79f800fec75592)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=e62eddcdbe3702ba95a833e0565cc3fdd5e23296
Author: Marek Olšák <marek.olsak at amd.com>
Date: Fri Jul 28 01:52:13 2017 +0200
st/mesa: release sampler views when redefining a texture in st_context_teximage
Noticed randomly.
Cc: 17.2 <mesa-stable at lists.freedesktop.org>
Reviewed-by: Nicolai Hähnle <nicolai.haehnle at amd.com>
(cherry picked from commit 5c1241268ba9b240cb79ab9a30c5255b176c83c9)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=6d07e58afb6bcbeec601391d936ddbd46a8c0622
Author: Dave Airlie <airlied at redhat.com>
Date: Thu Jul 27 04:51:48 2017 +0100
radv: for stencil only set Z tile mode index to same value
On SI this was causing a hang in
dEQP-VK.pipeline.render_to_image.core.2d_array.mipmap.r16g16_sint_s8_uint
This was due to not handling the tile mode index for depth like
I fixed previously for new GPUs.
Fixes: 01d0c5a9 (radv: fix stencil regression since new addrlib import)
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Signed-off-by: Dave Airlie <airlied at redhat.com>
(cherry picked from commit 800d1622096ca52b955bdfc20eb770b80ef15221)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f9e563597d670083145359f393d31ce69a19ab9b
Author: Dave Airlie <airlied at redhat.com>
Date: Fri Jul 28 11:04:35 2017 +1000
virgl: drop precise modifier.
The host doesn't understand this yet, so drop it for now.
Fixes: virgl regressions.
Fixes: af22adee4f (tgsi: add precise flag to tgsi_instruction)
Signed-off-by: Dave Airlie <airlied at redhat.com>
(cherry picked from commit 554aa094406f3f5a935c4adbe77569cc9beb4312)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=5b61ba4432ec272b74d9eb1b16d18e6a43879b3a
Author: Marek Olšák <marek.olsak at amd.com>
Date: Tue Jul 4 16:11:16 2017 +0200
radeonsi: update dirty_level_mask only when flushing or unbinding framebuffer
This fixes corruption with bindless textures in Dawn Of War 3.
The do_update_surf_dirtiness mechanism was complicated and dirty_level_mask
was only updated after the first draw call. The problem is bindless textures
are checked for decompression every draw call and we would only decompress
after the first draw call. The solution is to set dirtiness after the last
draw call to the framebuffer, so the (unconditional) decompression of
bindless textures happens at the right time.
Cc: 17.2 <mesa-stable at lists.freedesktop.org>
Tested-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
(cherry picked from commit f4d095cc651af005d5760aa9dd06e6ae7007fab6)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=6625382b1c036335972b53620ac0a5144c63fa10
Author: Marek Olšák <marek.olsak at amd.com>
Date: Tue Jul 25 17:34:52 2017 +0200
st/mesa: always unconditionally revalidate main framebuffer after SwapBuffers
This fixes the black Feral launcher window.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101867
Cc: 17.2 <mesa-stable at lists.freedesktop.org>
Tested-by: Edmondo Tommasina <edmondo.tommasina at gmail.com>
(cherry picked from commit 7257c171e9eadc05903140cffa26a253f0d0178a)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=2bca74253da64e15e49fa6ebaa11c99023a34e2c
Author: Nicolai Hähnle <nicolai.haehnle at amd.com>
Date: Fri Jul 14 14:33:37 2017 +0200
radeonsi/gfx9: always wrap GS and TCS in an if-block (v2)
With merged ESGS shaders, the GS part of a wave may be empty, and the
hardware gets confused if any GS messages are sent from that wave. Since
S_SENDMSG is executed even when EXEC = 0, we have to wrap even
non-monolithic GS shaders in an if-block, so that the entire shader and
hence the S_SENDMSG instructions are skipped in empty waves.
This change is not required for TCS/HS, but applying it there as well
simplifies the logic a bit.
Fixes GL45-CTS.geometry_shader.rendering.rendering.*
v2: ensure that the TCS epilog doesn't run for non-existing patches
Cc: mesa-stable at lists.freedesktop.org
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
(cherry picked from commit 081ac6e5c6d2ef3931b27eb755d1a38827582a45)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b36ff2d1f207656114701f83af513e382dc0e870
Author: Nicolai Hähnle <nicolai.haehnle at amd.com>
Date: Fri Jul 14 13:31:49 2017 +0200
radeonsi/gfx9: fix vertex idx in ES with multiple waves per threadgroup
Cc: mesa-stable at lists.freedesktop.org
Reviewed: Marek Olšák <marek.olsak at amd.com>
(cherry picked from commit 873789002f5d1c7c6c39231a8c8d541f4f61e65c)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=99b2613ce15c4391949ec221694b054c0910e68a
Author: George Kyriazis <george.kyriazis at intel.com>
Date: Fri Jul 21 23:23:04 2017 -0500
swr: fix transform feedback logic
The shader that is used to copy vertex data out of the vs/gs shaders to
the user-specified buffer (streamout or SO shader) was not using the
correct offsets.
Adjust the offsets that are used just for the SO shader:
- Make sure that position is handled in the same special way
as in the vs/gs shaders
- Use the correct offset to be passed in the core
- consolidate register slot mapping logic into one function, since it's
been calculated in 2 different places (one for calcuating the slot mask,
and one for the register offsets themselves
Also make room for all attibutes in the backend vertex area.
Fixes:
- all vtk GL2PS tests
- 18 piglit tests (16 ext_transform_feedback tests,
arb-quads-follow-provoking-vertex and primitive-type gl_points
v2:
- take care of more SGV slots in slot mapping logic
- trim feState.vsVertexSize
- fix GS interface and incorporate GS while calculating vsVertexSize
Note that vsVertexSize is used in the core as the one parameter that
controls vertex size between all stages, so it has to be adjusted appropriately
for the whole vs/gs/fs pipeline.
Also note that GS and SO is not fully implemented. This will be addressed
later.
fixes:
- fixes total of 20 piglit tests
CC: 17.2 <mesa-stable at lists.freedesktop.org>
Reviewed-by: Bruce Cherniak <bruce.cherniak at intel.com>
(cherry picked from commit 194ff5eed18f310bece0899595f678699badd32e)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f9c7549605e412e3b77c727a0d86442260f8f46a
Author: Dave Airlie <airlied at redhat.com>
Date: Wed Jul 26 02:34:54 2017 +0100
radv/ac: port SI TC L1 write corruption fix.
This ports 72e46c988 to radv.
radeonsi: apply a TC L1 write corruption workaround for SI
Fixes: f4e499ec7 (radv: add initial non-conformant radv vulkan driver)
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Signed-off-by: Dave Airlie <airlied at redhat.com>
(cherry picked from commit e77ff11ffe1a52b8e17a847f263746c849db3f11)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=2ce4f0afd375a8949d2154f05d60cc2fe9a57789
Author: Dave Airlie <airlied at redhat.com>
Date: Wed Jul 26 02:32:39 2017 +0100
radv/ac: realign SI workaround with radeonsi.
This ports: da7453666ae
radeonsi: don't apply the Z export bug workaround to Hainan
to radv.
Just noticed in passing.
Fixes: f4e499ec7 (radv: add initial non-conformant radv vulkan driver)
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Signed-off-by: Dave Airlie <airlied at redhat.com>
(cherry picked from commit a81e99f50a718790de379087c9f5a636e32b2a28)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=546282e8bcad99d8c68ea6afb8bce167328995f3
Author: Dave Airlie <airlied at redhat.com>
Date: Tue Jul 25 10:19:21 2017 +1000
radv: only report external semaphore info for opaque fd.
Until we support sync fd, don't report the info.
Fixes CTS dEQP-VK.api.external.semaphore.sync_fd.* from crashing.
Fixes: eaa56eab6 (radv: initial support for shared semaphores (v2))
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Signed-off-by: Dave Airlie <airlied at redhat.com>
(cherry picked from commit 6cbc8cf178e4984e464c9fe19434d1514d2ae37d)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=de55bc8f49d0487b9d56119c5caf7ff8b17915a1
Author: Dave Airlie <airlied at redhat.com>
Date: Mon Jul 24 11:42:54 2017 +0100
radv: fix buffer views on SI/CIK.
Fixes CTS dEQP-VK.memory.pipeline_barrier.host_write_uniform_texel_buffer.1024
on SI/CIK with radv.
Fixes: f4e499ec (radv: add initial non-conformant radv vulkan driver)
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Signed-off-by: Dave Airlie <airlied at redhat.com>
(cherry picked from commit ca82ef5ac75e50abb109986b55002cca24f7c0fb)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f0b7563a361bb252652b72a63b4b4eee130bb369
Author: Daniel Stone <daniels at collabora.com>
Date: Fri Jul 21 13:55:42 2017 +0100
st/dri2: Return invalid modifier when no driver support
Always initialise whandle.modifier for DRIImage modifier queries, so if
the driver doesn't support it then we return false for the query.
Signed-off-by: Daniel Stone <daniels at collabora.com>
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Fixes: d33fe8b84e45 ("st/dri: enable DRIimage modifier queries")
(cherry picked from commit 45383d32d4fd0265a7133704cb3e6c15620177cd)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=5bee1968400fadd3cfceb89ad1d5409cd8da1742
Author: Daniel Stone <daniels at collabora.com>
Date: Mon Jul 24 14:42:56 2017 +0100
st/dri: Check get-handle return value in queryImage
In the DRIImage queryImage hook, check if resource_get_handle() failed
and return FALSE if so.
Signed-off-by: Daniel Stone <daniels at collabora.com>
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
(cherry picked from commit b4a18f13ce7f0e7d0307fb3388819345616752ce)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=2a1792981ceee38799f637dd64c33f75f9769c7d
Author: Daniel Stone <daniels at collabora.com>
Date: Fri Jul 21 12:05:17 2017 +0100
egl/wayland: Ignore invalid modifiers
If the underlying driver does not support modifiers, dmabuf will still
advertise formats through the 'modifier' event, but send them with an
invalid modifier. Ignore them if this is the case, rather than passing
them through to the driver.
Signed-off-by: Daniel Stone <daniels at collabora.com>
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
Fixes: 02cc35937277 ("egl/wayland: Use linux-dmabuf interface for buffers")
(cherry picked from commit dd072cf4b131c8aa9e8be0ff24b70856fe39285e)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=a2b7477603caba35c497667de046e4e2809aa9fa
Author: Tim Rowley <timothy.o.rowley at intel.com>
Date: Wed Jul 26 15:17:49 2017 -0500
swr/rast: non-regex knob fallback code for gcc < 4.9
gcc prior to 4.9 didn't implement <regex>, causing a startup crash
in the swr knob parameter reading code.
CC: <mesa-stable at lists.freedesktop.org>
Reviewed-by: Bruce Cherniak <bruce.cherniak at intel.com>
(cherry picked from commit e21fc2c625279b29a3c05d3341b8b748655d5cec)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=3e777d5cabca3d91b9224eee47a01249e9afbcff
Author: Dave Airlie <airlied at redhat.com>
Date: Tue Jul 25 16:09:40 2017 +1000
virgl: encode index buffer offset.
Fixes arb_vertex_buffer_object-combined-vertex-index
Cc: mesa-stable at lists.freedesktop.org
Signed-off-by: Dave Airlie <airlied at redhat.com>
(cherry picked from commit c4652a0a5b5eef32f31baa1187ecd2612ac1009d)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=9bb6aa5794e58a54a55699bce3c04e0becf21e72
Author: Marek Olšák <marek.olsak at amd.com>
Date: Tue Jul 25 00:08:55 2017 +0200
ac/surface: fix hybrid graphics where APU=GFX9, dGPU=older
v2: don't do it for compressed textures (bpp = 0)
Cc: 17.2 <mesa-stable at lists.freedesktop.org>
Reviewed-by: Alex Deucher <alexander.deucher at amd.com> (v1)
Reviewed-by: Nicolai Hähnle <nicolai.haehnle at amd.com> (v1)
(cherry picked from commit 5e81df0f103667d888bd346e148843f510a80adc)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=90bbcb93b1963a3233a3571c81aa6341ab3da737
Author: Marek Olšák <marek.olsak at amd.com>
Date: Mon Jul 24 23:56:30 2017 +0200
radeonsi: decrease the number of compiler threads
Cc: 17.2 <mesa-stable at lists.freedesktop.org>
Reviewed-by: Nicolai Hähnle <nicolai.haehnle at amd.com>
(cherry picked from commit ed2b3f5c81b76281ff0e4728928ac55944b930b8)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=529c440dd306133e9fcab25c6a27110357d98fa9
Author: Marek Olšák <marek.olsak at amd.com>
Date: Tue Jul 25 17:29:58 2017 +0200
gallium/radeon: make S_FIXED function signed and move it to shared code
This fixes a bug uncovered by:
2412c4c81ea0488df865817a0de91ec46e359b72
util: Make CLAMP turn NaN into MIN.
Cc: 17.2 <mesa-stable at lists.freedesktop.org>
Reviewed-by: Roland Scheidegger <sroland at vmware.com>
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
Reviewed-by: Nicolai Hähnle <nicolai.haehnle at amd.com>
(cherry picked from commit 433f6f7ac9ed6624fec02cc055c3bfa247dba185)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=94e0de90eeb6407a63d4b780cd4cff6c5e7e794e
Author: Charmaine Lee <charmainel at vmware.com>
Date: Fri Jul 21 21:41:06 2017 -0700
st/mesa: create framebuffer iface hash table per st manager
With commit 5124bf98239, a framebuffer interface hash table is
created in st_gl_api_create(), which is called in
dri_init_screen_helper() for each screen. When the hash table is
overwritten with multiple calls to st_gl_api_create(), it can cause
race condition. This patch fixes the problem by creating a
framebuffer interface hash table per state tracker manager.
Fixes crash with steam.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101876
Fixes: 5124bf98239 ("st/mesa: add destroy_drawable interface")
Tested-by: Christoph Haag <haagch at frickel.club>
Reviewed-by: Brian Paul <brianp at vmware.com>
(cherry picked from commit bbc29393d3beaf6344c7188547b4ff61b63946ae)
Squashed with:
st/mesa: fix unconditional return in st_framebuffer_iface_remove
Noticed by James Legg @ Feral.
Cc: 17.2 <mesa-stable at lists.freedesktop.org>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
(cherry picked from commit 914f11e75b8ebe8a0faab76ce25fe185ab580eee)
Squashed with:
st/mesa: Fix inversed test in st_api_destroy_drawable
Fixes a drawable leak.
Fixes: bbc29393d3be ("st/mesa: create framebuffer iface hash table per
st manager")
Bugzilla: https://bugs.freedesktop.org/101930
Tested-by: Nick Sarnie <commendsarnex at gmail.com>
Reviewed-by: Brian Paul <brianp at vmware.com>
(cherry picked from commit 57132d126f2e129fc2959dcc2c0a8126389d07ba)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=3180f0fa0db6401d865b589d3bb75f2a852aad82
Author: Grigori Goronzy <greg at chown.ath.cx>
Date: Wed Jul 19 23:51:55 2017 +0200
egl: move KHR_no_error vs debug/robustness check further down
We'll fail to flag an error if the context flags appear after the
no-error attribute in the context attribute list.
Delay the check to after attribute parsing to fix this.
Fixes: 4909519a665 ("egl: Add EGL_KHR_create_context_no_error support")
Cc: mesa-stable at lists.freedesktop.org
[Emil Velikov: add fixes/stable tags, commit message polish]
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
(cherry picked from commit 39bf7756b9a56b4827fecabfca00a8139feecd25)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=e7f14a8b5260f44bd7db4bf75ee80e1a5abcbbb8
Author: Nicolai Hähnle <nicolai.haehnle at amd.com>
Date: Tue Jul 25 14:32:03 2017 +0200
radeonsi/gfx9: reduce max threads per block to 1024 on gfx9+
The number of supported waves per thread group has been reduced to 16
with gfx9. Trying to use 32 waves causes hangs, and barriers might
not work correctly with > 16 waves.
Cc: mesa-stable at lists.freedesktop.org
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
(cherry picked from commit a0e6b9a2db5aa5f06a4f60d270aca8344e7d8b3f)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=7f5d9d7a6d7ee1d9598ed13a02fa9342eb69605f
Author: Nicolai Hähnle <nicolai.haehnle at amd.com>
Date: Tue Jul 25 16:47:27 2017 +0200
radeonsi: fix detection of DRAW_INDIRECT_MULTI on SI
The firmware version numbers for SI were wrong. The new numbers are probably
too conservative (we don't have a definitive answer by the firmware team),
but DRAW_INDIRECT_MULTI has been confirmed to work with these versions on
Tahiti (by Gustaw) and on Verde (by myself).
While this is technically adding a feature, it's a feature we thought we had
for a long time. The change is small enough and we're early enough in the 17.2
release cycle that it should still go in.
Reported-by: Gustaw Smolarczyk <wielkiegie at gmail.com>
Cc: 17.2 <mesa-stable at lists.freedesktop.org>
Acked-by: Alex Deucher <alexander.deucher at amd.com>
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
(cherry picked from commit 65fbaab0b74b6b5a2ac483d48beeefa0a29ff15e)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=3d0960e76189133de04e4e416dcc17e0bc113320
Author: Iago Toral Quiroga <itoral at igalia.com>
Date: Fri Jul 21 08:32:24 2017 +0200
anv: only expose up to 28 vertex attributes
The EU limit of 128 GRFs should allow 32 vertex elements of 4 GRFs.
However, the maximum allowed value of "Vertex URB Entry Read Length"
in SIMD8 is 15. And 15 * 8 = 120 gives us a limit of 30 vertex elements.
Because we also need to reserve a vertex buffer to upload
VertexIndex/InstanceIndex and another to upload DrawID when needed,
we can only expose 28.
Cc: "17.2" <mesa-stable at lists.freedesktop.org>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
(cherry picked from commit 31f1863ace73d31a579e5c36252a957818ad09cf)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=bdbd8ab517f821f8705b71c2830b4dd687d45ed1
Author: Iago Toral Quiroga <itoral at igalia.com>
Date: Wed Jul 19 12:49:33 2017 +0200
anv/cmd_buffer: fix off by one error in assertion
Cc: "17.2" <mesa-stable at lists.freedesktop.org>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
(cherry picked from commit a848e693efc8e2a1d355dc1076409968b374153f)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=47bca2cfa74f26f554f39dde675610eb82ada1ce
Author: Kenneth Graunke <kenneth at whitecape.org>
Date: Tue Jul 25 10:22:01 2017 -0700
i965: Fix = vs == in MCS aux usage assert.
Caught by Coverity (CID 1415680).
Cc: "17.2" <mesa-stable at lists.freedesktop.org>
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
(cherry picked from commit 698636cc9762f090b75fd0421db7e654609e7715)
Fixes: 0f9b609cf4f ("i965/blorp: Do prepare/finish manually")
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=04bb687f043ca7e8e7fc3b56f62f5758667598b5
Author: Kenneth Graunke <kenneth at whitecape.org>
Date: Tue Jul 25 10:16:16 2017 -0700
i965: Fix offset addition in get_isl_surf.
Increase the value, not the pointer to the stack variable.
Caught by Coverity (CID 1415574). Not shipped in a real release.
Cc: "17.2" <mesa-stable at lists.freedesktop.org>
Reviewed-by: Topi Pohjolainen <topi.pohjolainen at intel.com>
(cherry picked from commit f6e674fa5164a957e93e8dc1334a48c9e7ee7df9)
Fixes: 63a43f41619 ("i965: Refactor miptree to isl converter and adjustment")
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=4e0f29ed0b844dd59773d7047af73a482461fa2b
Author: Eric Anholt <eric at anholt.net>
Date: Mon Jul 24 12:34:23 2017 -0700
broadcom/vc4: Prefer blit via rendering to the software fallback.
I don't know how I managed to leave this here for so long. Found when
working on a 1:1 overlapping blit extension for X11.
Cc: mesa-stable at lists.freedesktop.org
(cherry picked from commit 93fec49a75ce799bb6fe167f9409fd553a5781c6)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=0ccb853cc0435d118aec0ab1c53036d3a3be7e65
Author: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Date: Tue Jul 25 17:49:22 2017 +0100
i965: perf: flush batchbuffers at the beginning of queries
As Chris commented, it makes more sense to have batch buffer flushes
before the query. Usually applications like frame_retrace do a series
of queries and in that case, with flushes at the end of the queries,
we might still have the first query contained in 2 different batchs.
More generally it would be quite usual to have the query contained in
2 batch buffers because we never now what's the fill rate of the
current batch buffer.
If we move the flushing at the beginning of the queries, it's pretty
much guaranteed that queries will be contained in a single batch
buffer (unless the amount of commands is huge, but then it's only fair
to include reloading request times in the measurements).
Fixes: adafe4b733c02 ("i965: perf: minimize the chances to spread queries across batchbuffers")
Reported-by: Chris Wilson <chris at chris-wilson.co.uk>
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Cc: "17.2 17.1" <mesa-stable at lists.freedesktop.org>
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
(cherry picked from commit 9f439ae1201cb049ffedb9b0e2d4f393fb0a761e)
More information about the mesa-commit
mailing list