Mesa (master): egl/drm: Declare EGLConfig attrib array inside loop

Chad Versace chadversary at kemper.freedesktop.org
Thu Jun 22 19:41:28 UTC 2017


Module: Mesa
Branch: master
Commit: f8ad7f405492ae1b6b035dd41b6b4b77be51f719
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=f8ad7f405492ae1b6b035dd41b6b4b77be51f719

Author: Chad Versace <chadversary at chromium.org>
Date:   Thu Jun 22 11:00:41 2017 -0700

egl/drm: Declare EGLConfig attrib array inside loop

No behavioral change. Just a readability cleanup.

Instead of modifying this small array on each loop iteration, we now
initialize it in-place with the values it needs.

Reviewed-by: Eric Engestrom <eric at engestrom.ch>

---

 src/egl/drivers/dri2/platform_drm.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/egl/drivers/dri2/platform_drm.c b/src/egl/drivers/dri2/platform_drm.c
index 7f907aff6c..11928225b9 100644
--- a/src/egl/drivers/dri2/platform_drm.c
+++ b/src/egl/drivers/dri2/platform_drm.c
@@ -598,10 +598,7 @@ drm_add_configs_for_visuals(_EGLDriver *drv, _EGLDisplay *disp)
       { GBM_FORMAT_ARGB8888,    0x00ff0000, 0xff000000 },
       { GBM_FORMAT_RGB565,      0x0000f800, 0x00000000 },
    };
-   EGLint attr_list[] = {
-      EGL_NATIVE_VISUAL_ID, 0,
-      EGL_NONE,
-   };
+
    unsigned int format_count[ARRAY_SIZE(visuals)] = { 0 };
    unsigned int count = 0;
 
@@ -619,7 +616,10 @@ drm_add_configs_for_visuals(_EGLDriver *drv, _EGLDisplay *disp)
          if (visuals[j].red_mask != red || visuals[j].alpha_mask != alpha)
             continue;
 
-         attr_list[1] = visuals[j].format;
+         const EGLint attr_list[] = {
+            EGL_NATIVE_VISUAL_ID,  visuals[j].format,
+            EGL_NONE,
+         };
 
          dri2_conf = dri2_add_config(disp, dri2_dpy->driver_configs[i],
                count + 1, EGL_WINDOW_BIT, attr_list, NULL);




More information about the mesa-commit mailing list