Mesa (master): genxml: Silence about a billion unused parameter warnings

Ian Romanick idr at kemper.freedesktop.org
Wed Jun 28 21:50:26 UTC 2017


Module: Mesa
Branch: master
Commit: 36bd4a5f21f9e7060def6cf5501040b0509a2a00
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=36bd4a5f21f9e7060def6cf5501040b0509a2a00

Author: Ian Romanick <ian.d.romanick at intel.com>
Date:   Wed Jun 14 18:59:09 2017 -0700

genxml: Silence about a billion unused parameter warnings

v2: Use textwrap.dedent to make the source line a lot shorter.
Shortening (?) the line was requested by Jason.

v3: Simplify the texwrap.dedent usage.  Suggested by Dylan.

Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
Reviewed-by: Dylan Baker <dylan at pnwbakers.com>

---

 src/intel/genxml/gen_pack_header.py | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/src/intel/genxml/gen_pack_header.py b/src/intel/genxml/gen_pack_header.py
index fefbc9aecc..9021f008a8 100644
--- a/src/intel/genxml/gen_pack_header.py
+++ b/src/intel/genxml/gen_pack_header.py
@@ -8,6 +8,7 @@ import xml.parsers.expat
 import re
 import sys
 import copy
+import textwrap
 
 license =  """/*
  * Copyright (C) 2016 Intel Corporation
@@ -578,8 +579,12 @@ class Parser(object):
 
     def emit_pack_function(self, name, group):
         name = self.gen_prefix(name)
-        print("static inline void\n%s_pack(__gen_user_data *data, void * restrict dst,\n%sconst struct %s * restrict values)\n{" %
-              (name, ' ' * (len(name) + 6), name))
+        print(textwrap.dedent("""\
+            static inline void
+            %s_pack(__attribute__((unused)) __gen_user_data *data,
+                  %s__attribute__((unused)) void * restrict dst,
+                  %s__attribute__((unused)) const struct %s * restrict values)
+            {""") % (name, ' ' * len(name), ' ' * len(name), name))
 
         (dwords, length) = group.collect_dwords_and_length()
         if length:




More information about the mesa-commit mailing list