Mesa (master): radv: fix the dynamic buffer index in vkCmdBindDescriptorSets

Bas Nieuwenhuizen bnieuwenhuizen at kemper.freedesktop.org
Tue Mar 7 19:24:58 UTC 2017


Module: Mesa
Branch: master
Commit: 0941d1a574f46c558b0037be81d9a57004f4290b
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=0941d1a574f46c558b0037be81d9a57004f4290b

Author: Fredrik Höglund <fredrik at kde.org>
Date:   Tue Mar  7 01:53:20 2017 +0100

radv: fix the dynamic buffer index in vkCmdBindDescriptorSets

This fixes the wrong dynamic buffer descriptors being updated when
firstSet > 0.

Cc: 17.0 <mesa-stable at lists.freedesktop.org>
Signed-off-by: Fredrik Höglund <fredrik at kde.org>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>

---

 src/amd/vulkan/radv_cmd_buffer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
index 8213065..5b44ce8 100644
--- a/src/amd/vulkan/radv_cmd_buffer.c
+++ b/src/amd/vulkan/radv_cmd_buffer.c
@@ -1823,7 +1823,7 @@ void radv_CmdBindDescriptorSets(
 		radv_bind_descriptor_set(cmd_buffer, set, idx);
 
 		for(unsigned j = 0; j < set->layout->dynamic_offset_count; ++j, ++dyn_idx) {
-			unsigned idx = j + layout->set[i].dynamic_offset_start;
+			unsigned idx = j + layout->set[i + firstSet].dynamic_offset_start;
 			uint32_t *dst = cmd_buffer->dynamic_buffers + idx * 4;
 			assert(dyn_idx < dynamicOffsetCount);
 




More information about the mesa-commit mailing list