Mesa (master): i965: Shut up major()/minor() warnings.

Kenneth Graunke kwg at kemper.freedesktop.org
Tue Mar 21 21:11:22 UTC 2017


Module: Mesa
Branch: master
Commit: b15038a28991c73b4bd26c30cf1f0aba20d42d53
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=b15038a28991c73b4bd26c30cf1f0aba20d42d53

Author: Kenneth Graunke <kenneth at whitecape.org>
Date:   Mon Mar 20 16:03:07 2017 -0700

i965: Shut up major()/minor() warnings.

Recent glibc generates this warning:

brw_performance_query.c:1648:13: warning: In the GNU C Library, "minor" is defined
 by <sys/sysmacros.h>. For historical compatibility, it is
 currently defined by <sys/types.h> as well, but we plan to
 remove this soon. To use "minor", include <sys/sysmacros.h>
 directly. If you did not intend to use a system-defined macro
 "minor", you should undefine it after including <sys/types.h>.

    min = minor(sb.st_rdev);

So, include sys/sysmacros.h to shut up the warning.

v2: Use the AC_HEADER_MAJOR defines to figure out the right header
    (thanks to Jonathan Gray for helping me not break non-glibc systems)

Reviewed-by: Matt Turner <mattst88 at gmail.com> [v1]
Reviewed-by: Emil Velikov <emli.velikov at collabora.com>

---

 src/mesa/drivers/dri/i965/brw_performance_query.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/src/mesa/drivers/dri/i965/brw_performance_query.c b/src/mesa/drivers/dri/i965/brw_performance_query.c
index 2e04e091d2..4a94e4b3cc 100644
--- a/src/mesa/drivers/dri/i965/brw_performance_query.c
+++ b/src/mesa/drivers/dri/i965/brw_performance_query.c
@@ -42,6 +42,13 @@
 #include <limits.h>
 #include <dirent.h>
 
+/* put before sys/types.h to silence glibc warnings */
+#ifdef MAJOR_IN_MKDEV
+#include <sys/mkdev.h>
+#endif
+#ifdef MAJOR_IN_SYSMACROS
+#include <sys/sysmacros.h>
+#endif
 #include <sys/types.h>
 #include <sys/stat.h>
 #include <fcntl.h>




More information about the mesa-commit mailing list