Mesa (master): anv/image: Return early when unbinding an image

Jason Ekstrand jekstrand at kemper.freedesktop.org
Wed Mar 22 16:45:15 UTC 2017


Module: Mesa
Branch: master
Commit: c942faf8f37d14e7934a21c15ad2438dde2d501e
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=c942faf8f37d14e7934a21c15ad2438dde2d501e

Author: Jason Ekstrand <jason.ekstrand at intel.com>
Date:   Tue Mar 21 17:16:46 2017 -0700

anv/image: Return early when unbinding an image

Found by inspection.

Reviewed-by: Chad Versace <chadversary at chromium.org>
 Reviewed-by: Iago Toral Quiroga <itoral at igalia.com>
Cc: "17.0 13.0" <mesa-stable at lists.freedesktop.org>

---

 src/intel/vulkan/anv_image.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c
index 7be988ab81..33499abca1 100644
--- a/src/intel/vulkan/anv_image.c
+++ b/src/intel/vulkan/anv_image.c
@@ -335,14 +335,15 @@ VkResult anv_BindImageMemory(
    ANV_FROM_HANDLE(anv_device_memory, mem, _memory);
    ANV_FROM_HANDLE(anv_image, image, _image);
 
-   if (mem) {
-      image->bo = &mem->bo;
-      image->offset = memoryOffset;
-   } else {
+   if (mem == NULL) {
       image->bo = NULL;
       image->offset = 0;
+      return VK_SUCCESS;
    }
 
+   image->bo = &mem->bo;
+   image->offset = memoryOffset;
+
    if (image->aux_surface.isl.size > 0) {
 
       /* The offset and size must be a multiple of 4K or else the




More information about the mesa-commit mailing list