Mesa (master): freedreno: fix memory leak

Rob Clark robclark at kemper.freedesktop.org
Fri Mar 24 21:58:37 UTC 2017


Module: Mesa
Branch: master
Commit: c03f6f12bbe6fb491c9362b3fd5d39b9f4fd05fd
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=c03f6f12bbe6fb491c9362b3fd5d39b9f4fd05fd

Author: Rob Clark <robdclark at gmail.com>
Date:   Fri Mar 24 17:03:05 2017 -0400

freedreno: fix memory leak

Otherwise blitter would still hold a ref to, for example, sampler-
views.

To reproduce:

   glmark2 -b desktop:duration=2 --run-forever

Fixes: a8e6734 ("freedreno: support for using generic clear path")
Cc: "13.0 17.0" <mesa-stable at lists.freedesktop.org>
Signed-off-by: Rob Clark <robdclark at gmail.com>

---

 src/gallium/drivers/freedreno/freedreno_draw.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/gallium/drivers/freedreno/freedreno_draw.c b/src/gallium/drivers/freedreno/freedreno_draw.c
index edeb88bf34..a3c35cbce9 100644
--- a/src/gallium/drivers/freedreno/freedreno_draw.c
+++ b/src/gallium/drivers/freedreno/freedreno_draw.c
@@ -276,6 +276,8 @@ fd_blitter_clear(struct pipe_context *pctx, unsigned buffers,
 	util_blitter_restore_constant_buffer_state(blitter);
 	util_blitter_restore_vertex_states(blitter);
 	util_blitter_restore_fragment_states(blitter);
+	util_blitter_restore_textures(blitter);
+	util_blitter_restore_fb_state(blitter);
 	util_blitter_restore_render_cond(blitter);
 	util_blitter_unset_running_flag(blitter);
 




More information about the mesa-commit mailing list