Mesa (master): mesa/vbo: remove redundant _mesa_is_bufferobj() calls
Timothy Arceri
tarceri at kemper.freedesktop.org
Fri Mar 31 02:44:48 UTC 2017
Module: Mesa
Branch: master
Commit: 2e70de7d2f703cf81cbe114a99f6328045143c26
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=2e70de7d2f703cf81cbe114a99f6328045143c26
Author: Timothy Arceri <tarceri at itsqueeze.com>
Date: Thu Mar 30 21:14:43 2017 +1100
mesa/vbo: remove redundant _mesa_is_bufferobj() calls
This is already called inside the vbo_exec_vtx_{unmap,map}()
functions.
Reviewed-by: Brian Paul <brianp at vmware.com>
Reviewed-by: Nicolai Hähnle <nicolai.haehnle at amd.com>
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
---
src/mesa/vbo/vbo_exec_draw.c | 14 ++++----------
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/src/mesa/vbo/vbo_exec_draw.c b/src/mesa/vbo/vbo_exec_draw.c
index c2fcb663cb..df34f059b3 100644
--- a/src/mesa/vbo/vbo_exec_draw.c
+++ b/src/mesa/vbo/vbo_exec_draw.c
@@ -426,9 +426,7 @@ vbo_exec_vtx_flush(struct vbo_exec_context *exec, GLboolean keepUnmapped)
if (ctx->NewState)
_mesa_update_state( ctx );
- if (_mesa_is_bufferobj(exec->vtx.bufferobj)) {
- vbo_exec_vtx_unmap( exec );
- }
+ vbo_exec_vtx_unmap(exec);
if (0)
printf("%s %d %d\n", __func__, exec->vtx.prim_count,
@@ -443,19 +441,15 @@ vbo_exec_vtx_flush(struct vbo_exec_context *exec, GLboolean keepUnmapped)
exec->vtx.vert_count - 1,
NULL, 0, NULL);
- /* If using a real VBO, get new storage -- unless asked not to.
- */
- if (_mesa_is_bufferobj(exec->vtx.bufferobj) && !keepUnmapped) {
+ /* Get new storage -- unless asked not to. */
+ if (!keepUnmapped)
vbo_exec_vtx_map( exec );
- }
}
}
/* May have to unmap explicitly if we didn't draw:
*/
- if (keepUnmapped &&
- _mesa_is_bufferobj(exec->vtx.bufferobj) &&
- exec->vtx.buffer_map) {
+ if (keepUnmapped && exec->vtx.buffer_map) {
vbo_exec_vtx_unmap( exec );
}
More information about the mesa-commit
mailing list