Mesa (master): intel: gen decoder: don't check for size_t negative values
Lionel Landwerlin
llandwerlin at kemper.freedesktop.org
Tue May 9 15:59:18 UTC 2017
Module: Mesa
Branch: master
Commit: 4201b7d1bf4f3358c944065dd79c07fbdf561dbb
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=4201b7d1bf4f3358c944065dd79c07fbdf561dbb
Author: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Date: Mon May 8 18:47:06 2017 +0100
intel: gen decoder: don't check for size_t negative values
We should get either 0 or 1 here.
CID: 1373562 (Control flow issues)
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Acked-by: Matt Turner <mattst88 at gmail.com>
---
src/intel/common/gen_decoder.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/intel/common/gen_decoder.c b/src/intel/common/gen_decoder.c
index 15bba3274e..24147340f5 100644
--- a/src/intel/common/gen_decoder.c
+++ b/src/intel/common/gen_decoder.c
@@ -648,7 +648,7 @@ gen_spec_load_from_path(const struct gen_device_info *devinfo,
do {
buf = XML_GetBuffer(ctx.parser, XML_BUFFER_SIZE);
len = fread(buf, 1, XML_BUFFER_SIZE, input);
- if (len < 0) {
+ if (len == 0) {
fprintf(stderr, "fread: %m\n");
fclose(input);
free(filename);
More information about the mesa-commit
mailing list