Mesa (master): vulkan/wsi/wayland: Remove roundtrip when creating image

Daniel Stone daniels at kemper.freedesktop.org
Fri May 19 09:33:35 UTC 2017


Module: Mesa
Branch: master
Commit: afe8c8a2997950cd63076b7c9eba39e1858fee43
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=afe8c8a2997950cd63076b7c9eba39e1858fee43

Author: Daniel Stone <daniels at collabora.com>
Date:   Tue May  2 09:51:40 2017 +0100

vulkan/wsi/wayland: Remove roundtrip when creating image

There's no need to call wl_display_roundtrip() after trying to create a
buffer through wl_drm; if it succeeds then everything is fine, and if it
fails, then we get a fatal protocol error so can't recover anyway.

Additionally, doing a roundtrip on the default / main application queue,
is destructive anyway, so would need to be its own queue.

Signed-off-by: Daniel Stone <daniels at collabora.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Cc: mesa-stable at lists.freedesktop.org

---

 src/vulkan/wsi/wsi_common_wayland.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/vulkan/wsi/wsi_common_wayland.c b/src/vulkan/wsi/wsi_common_wayland.c
index a1904c02b9..2ff29736ae 100644
--- a/src/vulkan/wsi/wsi_common_wayland.c
+++ b/src/vulkan/wsi/wsi_common_wayland.c
@@ -698,7 +698,6 @@ wsi_wl_image_init(struct wsi_wl_swapchain *chain,
                                               offset,
                                               row_pitch,
                                               0, 0, 0, 0 /* unused */);
-   wl_display_roundtrip(chain->display->display);
    close(fd);
 
    if (!image->buffer)




More information about the mesa-commit mailing list