Mesa (master): glsl: set mask via initialisation list rather than in constructor body
Timothy Arceri
tarceri at kemper.freedesktop.org
Mon May 22 04:22:47 UTC 2017
Module: Mesa
Branch: master
Commit: 3ceae88642ddddf7c44b44df7b5c24ca0c7df878
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=3ceae88642ddddf7c44b44df7b5c24ca0c7df878
Author: Timothy Arceri <tarceri at itsqueeze.com>
Date: Sat May 20 13:54:20 2017 +1000
glsl: set mask via initialisation list rather than in constructor body
Potentially more efficient as it may avoid the struct being initialised
twice.
Also add var to the initialisation list while we are here.
Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
---
src/compiler/glsl/ir.cpp | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/src/compiler/glsl/ir.cpp b/src/compiler/glsl/ir.cpp
index 123de99005..2d0c4c051a 100644
--- a/src/compiler/glsl/ir.cpp
+++ b/src/compiler/glsl/ir.cpp
@@ -1590,10 +1590,8 @@ ir_swizzle::ir_swizzle(ir_rvalue *val, const unsigned *comp,
}
ir_swizzle::ir_swizzle(ir_rvalue *val, ir_swizzle_mask mask)
- : ir_rvalue(ir_type_swizzle)
+ : ir_rvalue(ir_type_swizzle), mask(mask), val(val)
{
- this->val = val;
- this->mask = mask;
this->type = glsl_type::get_instance(val->type->base_type,
mask.num_components, 1);
}
More information about the mesa-commit
mailing list