Mesa (master): radeonsi: drop useless memcmp() check in si_set_blend_color ()

Samuel Pitoiset hakzsam at kemper.freedesktop.org
Sat May 27 16:01:22 UTC 2017


Module: Mesa
Branch: master
Commit: ab8fb5a082513bb699b224c52ac82779752608fb
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=ab8fb5a082513bb699b224c52ac82779752608fb

Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date:   Fri May 26 01:42:53 2017 +0200

radeonsi: drop useless memcmp() check in si_set_blend_color()

cso_set_blend_color() already checks if the old state is different.
Only Nine uses pipe::set_blend_color() directly but I guess it
should use the cache too.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Marek Olšák <marek.olsak at amd.com>

---

 src/gallium/drivers/radeonsi/si_state.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c
index 363f32170a..ae7c91f475 100644
--- a/src/gallium/drivers/radeonsi/si_state.c
+++ b/src/gallium/drivers/radeonsi/si_state.c
@@ -619,9 +619,6 @@ static void si_set_blend_color(struct pipe_context *ctx,
 {
 	struct si_context *sctx = (struct si_context *)ctx;
 
-	if (memcmp(&sctx->blend_color.state, state, sizeof(*state)) == 0)
-		return;
-
 	sctx->blend_color.state = *state;
 	si_mark_atom_dirty(sctx, &sctx->blend_color.atom);
 }




More information about the mesa-commit mailing list