Mesa (master): freedreno/a5xx: drop WFIs in emit_marker5()

Rob Clark robclark at kemper.freedesktop.org
Wed May 31 01:04:12 UTC 2017


Module: Mesa
Branch: master
Commit: 45e97c994bb5019dd1be35cc76216a4774c8b2b6
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=45e97c994bb5019dd1be35cc76216a4774c8b2b6

Author: Rob Clark <robdclark at gmail.com>
Date:   Tue May 30 11:19:12 2017 -0400

freedreno/a5xx: drop WFIs in emit_marker5()

Results in always having at least one WFI between draws, which was
slowing stk down by ~5% and ~10% in xonotic.

(also drop bogus assert while we're at it.)

Signed-off-by: Rob Clark <robdclark at gmail.com>

---

 src/gallium/drivers/freedreno/freedreno_util.h | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/src/gallium/drivers/freedreno/freedreno_util.h b/src/gallium/drivers/freedreno/freedreno_util.h
index 6b0fb700d6..a0e1334e78 100644
--- a/src/gallium/drivers/freedreno/freedreno_util.h
+++ b/src/gallium/drivers/freedreno/freedreno_util.h
@@ -410,13 +410,8 @@ emit_marker5(struct fd_ringbuffer *ring, int scratch_idx)
 	extern unsigned marker_cnt;
 //XXX	unsigned reg = REG_A5XX_CP_SCRATCH_REG(scratch_idx);
 	unsigned reg = 0x00000b78 + scratch_idx;
-	assert(reg != HW_QUERY_BASE_REG);
-	if (reg == HW_QUERY_BASE_REG)
-		return;
-	OUT_WFI5(ring);
 	OUT_PKT4(ring, reg, 1);
 	OUT_RING(ring, ++marker_cnt);
-	OUT_WFI5(ring);
 }
 
 /* helper to get numeric value from environment variable..  mostly




More information about the mesa-commit mailing list