Mesa (master): glsl: Remove program_resource_visitor::visit_field( const glsl_struct_field *)

Ian Romanick idr at kemper.freedesktop.org
Thu Nov 9 02:37:49 UTC 2017


Module: Mesa
Branch: master
Commit: ae1fd09c1d5cad98c9c5e92fbc32ec5af79d210c
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=ae1fd09c1d5cad98c9c5e92fbc32ec5af79d210c

Author: Ian Romanick <ian.d.romanick at intel.com>
Date:   Tue Oct 31 15:06:24 2017 -0700

glsl: Remove program_resource_visitor::visit_field(const glsl_struct_field *)

I could not find any remaining users.

Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
Reviewed-by: Nicolai Hähnle <nicolai.haehnle at amd.com>

---

 src/compiler/glsl/link_uniforms.cpp |  8 --------
 src/compiler/glsl/linker.h          | 10 ----------
 2 files changed, 18 deletions(-)

diff --git a/src/compiler/glsl/link_uniforms.cpp b/src/compiler/glsl/link_uniforms.cpp
index 30c48b94fc..4aa29f45b2 100644
--- a/src/compiler/glsl/link_uniforms.cpp
+++ b/src/compiler/glsl/link_uniforms.cpp
@@ -132,9 +132,6 @@ program_resource_visitor::recursion(const glsl_type *t, char **name,
          const char *field = t->fields.structure[i].name;
          size_t new_length = name_length;
 
-         if (t->fields.structure[i].type->is_record())
-            this->visit_field(&t->fields.structure[i]);
-
          if (t->is_interface() && t->fields.structure[i].offset != -1)
             this->set_buffer_offset(t->fields.structure[i].offset);
 
@@ -216,11 +213,6 @@ program_resource_visitor::recursion(const glsl_type *t, char **name,
 }
 
 void
-program_resource_visitor::visit_field(const glsl_struct_field *)
-{
-}
-
-void
 program_resource_visitor::enter_record(const glsl_type *, const char *, bool,
                                        const enum glsl_interface_packing)
 {
diff --git a/src/compiler/glsl/linker.h b/src/compiler/glsl/linker.h
index 5cec121e63..03ed9d5f84 100644
--- a/src/compiler/glsl/linker.h
+++ b/src/compiler/glsl/linker.h
@@ -159,16 +159,6 @@ protected:
                             const enum glsl_interface_packing packing,
                             bool last_field) = 0;
 
-   /**
-    * Visit a record before visiting its fields
-    *
-    * For structures-of-structures or interfaces-of-structures, this visits
-    * the inner structure before visiting its fields.
-    *
-    * The default implementation does nothing.
-    */
-   virtual void visit_field(const glsl_struct_field *field);
-
    virtual void enter_record(const glsl_type *type, const char *name,
                              bool row_major, const enum glsl_interface_packing packing);
 




More information about the mesa-commit mailing list