Mesa (master): radv: remove unnecessary memset() in radv_AllocateCommandBuffers()

Samuel Pitoiset hakzsam at kemper.freedesktop.org
Mon Nov 13 10:08:40 UTC 2017


Module: Mesa
Branch: master
Commit: 0f68208f1d1d3b7b2963dab40e84c60212518692
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=0f68208f1d1d3b7b2963dab40e84c60212518692

Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date:   Fri Nov 10 09:18:01 2017 +0100

radv: remove unnecessary memset() in radv_AllocateCommandBuffers()

This should not be needed, if the allocation fails an error is
returned and the host should handle it.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>

---

 src/amd/vulkan/radv_cmd_buffer.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
index 5f518f04ac..8d69d2935a 100644
--- a/src/amd/vulkan/radv_cmd_buffer.c
+++ b/src/amd/vulkan/radv_cmd_buffer.c
@@ -2142,9 +2142,6 @@ VkResult radv_AllocateCommandBuffers(
 	VkResult result = VK_SUCCESS;
 	uint32_t i;
 
-	memset(pCommandBuffers, 0,
-			sizeof(*pCommandBuffers)*pAllocateInfo->commandBufferCount);
-
 	for (i = 0; i < pAllocateInfo->commandBufferCount; i++) {
 
 		if (!list_empty(&pool->free_cmd_buffers)) {




More information about the mesa-commit mailing list