Mesa (master): intel/tools/error: Drop unused parameters from decode() helper.

Kenneth Graunke kwg at kemper.freedesktop.org
Tue Nov 14 01:11:23 UTC 2017


Module: Mesa
Branch: master
Commit: 00981e7c477e13e5328d7de1d548bfd1151f167c
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=00981e7c477e13e5328d7de1d548bfd1151f167c

Author: Kenneth Graunke <kenneth at whitecape.org>
Date:   Sat Nov 11 22:17:30 2017 -0800

intel/tools/error: Drop unused parameters from decode() helper.

Also change count from a pointer into a value.  We were supposed to
be resetting it to 0 (and failed to), but that's gone since we dropped
the pre-ascii85 handling.

Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

---

 src/intel/tools/aubinator_error_decode.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/src/intel/tools/aubinator_error_decode.c b/src/intel/tools/aubinator_error_decode.c
index 279f1ac01c..94436e957d 100644
--- a/src/intel/tools/aubinator_error_decode.c
+++ b/src/intel/tools/aubinator_error_decode.c
@@ -233,13 +233,11 @@ static int next_program(void)
 }
 
 static void decode(struct gen_spec *spec,
-                   const char *buffer_name,
-                   const char *ring_name,
                    uint64_t gtt_offset,
                    uint32_t *data,
-                   int *count)
+                   int count)
 {
-   uint32_t *p, *end = (data + *count);
+   uint32_t *p, *end = (data + count);
    int length;
    struct gen_group *inst;
    uint64_t current_instruction_base_address = 0;
@@ -530,7 +528,7 @@ read_data_file(FILE *file)
                }
             }
          } else {
-            decode(spec, buffer_name, ring_name, gtt_offset, data, &count);
+            decode(spec, gtt_offset, data, count);
          }
          free(data);
          continue;




More information about the mesa-commit mailing list