Mesa (master): Revert "radv: remove unnecessary memset() in radv_AllocateCommandBuffers()"

Samuel Pitoiset hakzsam at kemper.freedesktop.org
Fri Nov 24 11:27:24 UTC 2017


Module: Mesa
Branch: master
Commit: 1cc00b8e0eb839096c1d6856df9213d6bad474ef
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=1cc00b8e0eb839096c1d6856df9213d6bad474ef

Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date:   Wed Nov 22 16:13:28 2017 +0100

Revert "radv: remove unnecessary memset() in radv_AllocateCommandBuffers()"

This fixes two CTS regressions:
- dEQP-VK.api.object_management.alloc_callback_fail_multiple.command_buffer_primary
- dEQP-VK.api.object_management.alloc_callback_fail_multiple.command_buffer_secondary

These two tests are part the mustpass lists, so presumably they
are correct and my change was wrong.

This reverts commit 0f68208f1d1d3b7b2963dab40e84c60212518692.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>

---

 src/amd/vulkan/radv_cmd_buffer.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
index 7d86eee979..bd72ba2a87 100644
--- a/src/amd/vulkan/radv_cmd_buffer.c
+++ b/src/amd/vulkan/radv_cmd_buffer.c
@@ -2139,6 +2139,9 @@ VkResult radv_AllocateCommandBuffers(
 	VkResult result = VK_SUCCESS;
 	uint32_t i;
 
+	memset(pCommandBuffers, 0,
+			sizeof(*pCommandBuffers)*pAllocateInfo->commandBufferCount);
+
 	for (i = 0; i < pAllocateInfo->commandBufferCount; i++) {
 
 		if (!list_empty(&pool->free_cmd_buffers)) {




More information about the mesa-commit mailing list