Mesa (master): mesa/main: R10G10B10_(A2) formats are not color renderable in ES
Nicolai Hähnle
nh at kemper.freedesktop.org
Mon Oct 2 13:07:58 UTC 2017
Module: Mesa
Branch: master
Commit: d2b60e433e50032e398fb92181f22a78601a5538
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d2b60e433e50032e398fb92181f22a78601a5538
Author: Nicolai Hähnle <nicolai.haehnle at amd.com>
Date: Wed Sep 27 15:25:10 2017 +0200
mesa/main: R10G10B10_(A2) formats are not color renderable in ES
The EXT_texture_type_2_10_10_10_REV (ES only) states the following issue:
"1. Should textures specified with this type be renderable?
UNRESOLVED: No. A separate extension could provide this functionality."
This partially fixes
dEQP-GLES3.functional.fbo.completeness.renderable.texture.color0.{rgb,rgba}_unsigned_int_2_10_10_10_rev
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
---
src/mesa/main/fbobject.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c
index 4d6fdfcd6b..0867ff70fa 100644
--- a/src/mesa/main/fbobject.c
+++ b/src/mesa/main/fbobject.c
@@ -737,8 +737,11 @@ is_format_color_renderable(const struct gl_context *ctx, mesa_format format,
break;
}
- if (format == MESA_FORMAT_B10G10R10A2_UNORM &&
- internalFormat != GL_RGB10_A2) {
+ if (internalFormat != GL_RGB10_A2 &&
+ (format == MESA_FORMAT_B10G10R10A2_UNORM ||
+ format == MESA_FORMAT_B10G10R10X2_UNORM ||
+ format == MESA_FORMAT_R10G10B10A2_UNORM ||
+ format == MESA_FORMAT_R10G10B10X2_UNORM)) {
return GL_FALSE;
}
More information about the mesa-commit
mailing list