Mesa (master): anv: Remove base_vertex/instance from push_constants

Jason Ekstrand jekstrand at kemper.freedesktop.org
Tue Oct 3 20:41:10 UTC 2017


Module: Mesa
Branch: master
Commit: 8733567e056360fbad7d99f56a64279957bdcf06
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=8733567e056360fbad7d99f56a64279957bdcf06

Author: Jason Ekstrand <jason.ekstrand at intel.com>
Date:   Wed Sep 27 17:01:27 2017 -0700

anv: Remove base_vertex/instance from push_constants

This is just legacy cruft.  We don't push these values; we pass them in
as vertex attributes.

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>

---

 src/intel/vulkan/anv_private.h | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h
index 3ba623a37f..b58c803530 100644
--- a/src/intel/vulkan/anv_private.h
+++ b/src/intel/vulkan/anv_private.h
@@ -1560,13 +1560,6 @@ struct anv_push_constants {
    /* Push constant data provided by the client through vkPushConstants */
    uint8_t client_data[MAX_PUSH_CONSTANTS_SIZE];
 
-   /* Our hardware only provides zero-based vertex and instance id so, in
-    * order to satisfy the vulkan requirements, we may have to push one or
-    * both of these into the shader.
-    */
-   uint32_t base_vertex;
-   uint32_t base_instance;
-
    /* Image data for image_load_store on pre-SKL */
    struct brw_image_param images[MAX_IMAGES];
 };




More information about the mesa-commit mailing list