Mesa (master): i965: Only insert error message if not already present
Matt Turner
mattst88 at kemper.freedesktop.org
Wed Oct 4 21:09:49 UTC 2017
Module: Mesa
Branch: master
Commit: 122ef3799d5612748afd8b15392c4a819a1b1847
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=122ef3799d5612748afd8b15392c4a819a1b1847
Author: Matt Turner <mattst88 at gmail.com>
Date: Mon Sep 18 14:07:20 2017 -0700
i965: Only insert error message if not already present
Some restrictions require something like strides to match between src
and dest. For multi-source instructions, I'd rather encapsulate the
logic for not inserting already present errors in ERROR_IF than
open-coding it multiple places.
---
src/intel/compiler/brw_eu_validate.c | 18 +++++++++++++-----
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/src/intel/compiler/brw_eu_validate.c b/src/intel/compiler/brw_eu_validate.c
index 99abc6b4f9..8fcc529366 100644
--- a/src/intel/compiler/brw_eu_validate.c
+++ b/src/intel/compiler/brw_eu_validate.c
@@ -44,15 +44,23 @@ cat(struct string *dest, const struct string src)
}
#define CAT(dest, src) cat(&dest, (struct string){src, strlen(src)})
+static bool
+contains(const struct string haystack, const struct string needle)
+{
+ return memmem(haystack.str, haystack.len, needle.str, needle.len) != NULL;
+}
+#define CONTAINS(haystack, needle) \
+ contains(haystack, (struct string){needle, strlen(needle)})
+
#define error(str) "\tERROR: " str "\n"
#define ERROR_INDENT "\t "
#define ERROR(msg) ERROR_IF(true, msg)
-#define ERROR_IF(cond, msg) \
- do { \
- if (cond) { \
- CAT(error_msg, error(msg)); \
- } \
+#define ERROR_IF(cond, msg) \
+ do { \
+ if ((cond) && !CONTAINS(error_msg, error(msg))) { \
+ CAT(error_msg, error(msg)); \
+ } \
} while(0)
#define CHECK(func, args...) \
More information about the mesa-commit
mailing list