Mesa (master): radv: don't flush the VS when srcStageMask == TOP_OF_PIPE_BIT

Samuel Pitoiset hakzsam at kemper.freedesktop.org
Fri Oct 20 09:39:00 UTC 2017


Module: Mesa
Branch: master
Commit: e2053b8e3d45af48f35973ddb55993353b597753
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=e2053b8e3d45af48f35973ddb55993353b597753

Author: Fredrik Höglund <fredrik at kde.org>
Date:   Thu Oct 19 20:54:50 2017 +0200

radv: don't flush the VS when srcStageMask == TOP_OF_PIPE_BIT

The Vulkan specification says:

   "... an execution dependency with only VK_PIPELINE_STAGE_TOP_OF_-
    PIPE_BIT in the source stage mask will effectively not wait for
    any prior commands to complete."

Signed-off-by: Fredrik Höglund <fredrik at kde.org>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>

---

 src/amd/vulkan/radv_cmd_buffer.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
index 2d59e47563..ac76d88706 100644
--- a/src/amd/vulkan/radv_cmd_buffer.c
+++ b/src/amd/vulkan/radv_cmd_buffer.c
@@ -1849,8 +1849,7 @@ static void radv_stage_flush(struct radv_cmd_buffer *cmd_buffer,
 			      VK_PIPELINE_STAGE_ALL_GRAPHICS_BIT |
 			      VK_PIPELINE_STAGE_ALL_COMMANDS_BIT)) {
 		cmd_buffer->state.flush_bits |= RADV_CMD_FLAG_PS_PARTIAL_FLUSH;
-	} else if (src_stage_mask & (VK_PIPELINE_STAGE_TOP_OF_PIPE_BIT |
-	                             VK_PIPELINE_STAGE_DRAW_INDIRECT_BIT |
+	} else if (src_stage_mask & (VK_PIPELINE_STAGE_DRAW_INDIRECT_BIT |
 	                             VK_PIPELINE_STAGE_VERTEX_INPUT_BIT |
 	                             VK_PIPELINE_STAGE_VERTEX_SHADER_BIT)) {
 		cmd_buffer->state.flush_bits |= RADV_CMD_FLAG_VS_PARTIAL_FLUSH;




More information about the mesa-commit mailing list