Mesa (master): radv: Don't reset cmd_buffer->state.dirty.

Bas Nieuwenhuizen bnieuwenhuizen at kemper.freedesktop.org
Sat Oct 21 18:02:46 UTC 2017


Module: Mesa
Branch: master
Commit: 20fb15bfe4888c8a09e3ace668caeb9e805e350e
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=20fb15bfe4888c8a09e3ace668caeb9e805e350e

Author: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Date:   Sat Oct 21 18:20:24 2017 +0200

radv: Don't reset cmd_buffer->state.dirty.

Otherwise for non-indexed draws we set and immediately unset
RADV_CMD_DIRTY_INDEX_BUFFER. As all the set functions should
clear their own bit, this is unnecessary.

Fixes: 341529dbee5 'radv: use optimal packet order for draws'
Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>

---

 src/amd/vulkan/radv_cmd_buffer.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
index 887b789df8..7ba0ea00f7 100644
--- a/src/amd/vulkan/radv_cmd_buffer.c
+++ b/src/amd/vulkan/radv_cmd_buffer.c
@@ -3151,8 +3151,6 @@ radv_emit_all_graphics_states(struct radv_cmd_buffer *cmd_buffer,
 	radv_emit_draw_registers(cmd_buffer, info->indexed,
 				 info->instance_count > 1, info->indirect,
 				 info->indirect ? 0 : info->count);
-
-	cmd_buffer->state.dirty = 0;
 }
 
 static void




More information about the mesa-commit mailing list