Mesa (master): mesa/bufferobj: don't double negate the range
Dave Airlie
airlied at kemper.freedesktop.org
Mon Oct 23 22:40:40 UTC 2017
Module: Mesa
Branch: master
Commit: 11d688d9f0d2ee4d0178d1807c0075e5e8364b1d
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=11d688d9f0d2ee4d0178d1807c0075e5e8364b1d
Author: Dave Airlie <airlied at redhat.com>
Date: Mon Oct 23 10:34:54 2017 +1000
mesa/bufferobj: don't double negate the range
This fixes a regression I introduced refactoring this code,
I managed to invert range twice, I moved the inversion into
the common code, but forgot to stop doing it in the callee.
Fixes: GL45-CTS.multi_bind.dispatch_bind_buffers_base
Fixes: 35ac13ed3 (mesa/bufferobj: consolidate some codepaths between ubo/ssbo/atomics.)
Reported-by: Nicolai Hähnle <nicolai.haehnle at amd.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Signed-off-by: Dave Airlie <airlied at redhat.com>
---
src/mesa/main/bufferobj.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c
index b7a969265a..dfeea94bd1 100644
--- a/src/mesa/main/bufferobj.c
+++ b/src/mesa/main/bufferobj.c
@@ -3815,7 +3815,7 @@ bind_uniform_buffers(struct gl_context *ctx, GLuint first, GLsizei count,
}
set_buffer_multi_binding(ctx, buffers, i, caller,
- binding, offset, size, !range,
+ binding, offset, size, range,
USAGE_UNIFORM_BUFFER);
}
@@ -3916,7 +3916,7 @@ bind_shader_storage_buffers(struct gl_context *ctx, GLuint first,
}
set_buffer_multi_binding(ctx, buffers, i, caller,
- binding, offset, size, !range,
+ binding, offset, size, range,
USAGE_SHADER_STORAGE_BUFFER);
}
@@ -4238,7 +4238,7 @@ bind_atomic_buffers(struct gl_context *ctx,
}
set_buffer_multi_binding(ctx, buffers, i, caller,
- binding, offset, size, !range,
+ binding, offset, size, range,
USAGE_ATOMIC_COUNTER_BUFFER);
}
More information about the mesa-commit
mailing list