Mesa (master): freedreno/a5xx: mem2gmem is read-only for BO

Rob Clark robclark at kemper.freedesktop.org
Thu Oct 26 12:40:04 UTC 2017


Module: Mesa
Branch: master
Commit: 4afcadbcc29b09a09573d3c144a0dd9712190ed1
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=4afcadbcc29b09a09573d3c144a0dd9712190ed1

Author: Rob Clark <robdclark at gmail.com>
Date:   Thu Oct  5 17:05:03 2017 -0400

freedreno/a5xx: mem2gmem is read-only for BO

This should be OUT_RELOC() since the operation isn't writing to the
buffer.  Technically it doesn't matter much currently, since we'd
anyways to a gmem2mem later.  But that will change.

Signed-off-by: Rob Clark <robdclark at gmail.com>

---

 src/gallium/drivers/freedreno/a5xx/fd5_gmem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/drivers/freedreno/a5xx/fd5_gmem.c b/src/gallium/drivers/freedreno/a5xx/fd5_gmem.c
index d8d79217d5..16c2f825d5 100644
--- a/src/gallium/drivers/freedreno/a5xx/fd5_gmem.c
+++ b/src/gallium/drivers/freedreno/a5xx/fd5_gmem.c
@@ -547,7 +547,7 @@ fd5_emit_tile_mem2gmem(struct fd_batch *batch, struct fd_tile *tile)
 				A5XX_RB_MRT_BUF_INFO_COLOR_SWAP(WZYX));
 		OUT_RING(ring, A5XX_RB_MRT_PITCH(slice->pitch * rsc->cpp));
 		OUT_RING(ring, A5XX_RB_MRT_ARRAY_PITCH(slice->size0));
-		OUT_RELOCW(ring, rsc->bo, 0, 0, 0);  /* BASE_LO/HI */
+		OUT_RELOC(ring, rsc->bo, 0, 0, 0);  /* BASE_LO/HI */
 
 		emit_mem2gmem_surf(batch, ctx->gmem.zsbuf_base[0], pfb->zsbuf, BLIT_MRT0);
 	}




More information about the mesa-commit mailing list