Mesa (17.2): 21 new commits
Andres Gomez
tanty at kemper.freedesktop.org
Fri Oct 27 17:43:37 UTC 2017
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=162fa27b12489d475fbb9d12e7e620f47500c0c9
Author: Andres Gomez <agomez at igalia.com>
Date: Wed Oct 25 04:19:13 2017 +0300
cherry-ignore: broadcom/vc5: Propagate vc4 aliasing fix to vc5.
extra: Commit is not applicable when ade416d0236 is missing.
Signed-off-by: Andres Gomez <agomez at igalia.com>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b3207d9ff793dd3163f62ab85047675140d0f8d2
Author: Andres Gomez <agomez at igalia.com>
Date: Wed Oct 25 04:13:05 2017 +0300
cherry-ignore: mesa/bufferobj: don't double negate the range
fixes: This commit addressed earlier commit 35ac13ed3 which did not
land in branch.
Signed-off-by: Andres Gomez <agomez at igalia.com>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=6cab29e9736d7bdc130095b73e028c4c5d9f8c6c
Author: Andres Gomez <agomez at igalia.com>
Date: Wed Oct 25 04:09:45 2017 +0300
cherry-ignore: radv: Disallow indirect outputs for GS on GFX9 as well.
fixes: Commit is not applicable when 6ce550453f1 is missing.
Signed-off-by: Andres Gomez <agomez at igalia.com>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=1c2f79066cc7a7f3024197a620a4d358c3237853
Author: Andres Gomez <agomez at igalia.com>
Date: Wed Oct 25 04:06:49 2017 +0300
cherry-ignore: radv: Don't use vgpr indexing for outputs on GFX9.
fixes: Commit is not applicable when 087e010b2b3 is missing.
Signed-off-by: Andres Gomez <agomez at igalia.com>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=0c63d53765664201946b645874a102e4fbdcad7b
Author: Andres Gomez <agomez at igalia.com>
Date: Wed Oct 25 03:53:26 2017 +0300
cherry-ignore: added 17.3 nominations.
stable: 17.3 nominations only.
Signed-off-by: Andres Gomez <agomez at igalia.com>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=52019bad1dbd4abd5a89957c70490827ef6367ec
Author: Andres Gomez <agomez at igalia.com>
Date: Thu Oct 26 16:15:47 2017 +0300
cherry-ignore: glsl: fix derived cs variables
stable: Commit is too big for stable at this point.
Signed-off-by: Andres Gomez <agomez at igalia.com>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=9bdd943ff258a0d942a7e49fa6a57ee0a75c9427
Author: Andres Gomez <agomez at igalia.com>
Date: Thu Oct 26 16:10:54 2017 +0300
cherry-ignore: configure.ac: rework llvm detection and handling
stable: Commits are too invasive for 17.2.
Signed-off-by: Andres Gomez <agomez at igalia.com>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=1393d37d7bd5ff3834ec8fe1948a8a900f844a3e
Author: Jason Ekstrand <jason.ekstrand at intel.com>
Date: Thu Aug 31 11:42:00 2017 -0700
intel/eu: Use EXECUTE_1 for JMPI
The PRM says "The execution size must be 1." In 73137997e23ff6c11, the
execution size was set to 1 when it should have been BRW_EXECUTE_1
(which maps to 0). Later, in dc2d3a7f5c217a7cee9, JMPI was used for
line AA on gen6 and earlier and we started manually stomping the
exeution size to BRW_EXECUTE_1 in the generator. This commit fixes the
original bug and makes brw_JMPI just do the right thing.
Reviewed-by: Matt Turner <mattst88 at gmail.com>
Fixes: 73137997e23ff6c1145d036315d1a9ad96651281
(cherry picked from commit 562b8d458c2de262019da2c056f75cb9feb5ee54)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=74f19032341748ad257a0c2527624b661e2d2e6f
Author: Jason Ekstrand <jason.ekstrand at intel.com>
Date: Mon Oct 2 09:53:50 2017 -0700
anv/pipeline: Call nir_lower_system_valaues after brw_preprocess_nir
We currently have a bug where nir_lower_system_values gets called before
nir_lower_var_copies so it will miss any system value uses which come
from a copy_var intrinsic. Moving it to after brw_preprocess_nir fixes
this problem.
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Cc: mesa-stable at lists.freedesktop.org
(cherry picked from commit 279f8fb69cf68d05287e14f60cf67fc025643bc4)
[Andres Gomez: resolve trivial conflicts]
Signed-off-by: Andres Gomez <agomez at igalia.com>
Conflicts:
src/intel/vulkan/anv_pipeline.c
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=aac0807f4843d42690119007a5c40fe03714accf
Author: Jason Ekstrand <jason.ekstrand at intel.com>
Date: Wed Sep 6 18:33:38 2017 -0700
intel/fs: Handle flag read/write aliasing in needs_src_copy
In order to implement the ballot intrinsic, we do a MOV from flag
register to some GRF. If that GRF is used in a SEL, cmod propagation
helpfully changes it into a MOV from the flag register with a cmod.
This is perfectly valid but when lower_simd_width comes along, it simply
splits into two instructions which both have conditional modifiers.
This is a problem since we're reading the flag register. This commit
makes us check whether or not flags_written() overlaps with the flag
values that we are reading via the instruction source and, if we have
any interference, will force us to emit a copy of the source.
Reviewed-by: Matt Turner <mattst88 at gmail.com>
Cc: mesa-stable at lists.freedesktop.org
(cherry picked from commit fa6e74e33e5bc5f6fba8f9de76b8b059515e708f)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=03f3899f99163f918d107fd91d486b87a9d51aa2
Author: Jan Vesely <jan.vesely at rutgers.edu>
Date: Sat Oct 21 15:38:54 2017 -0400
clover: Fix compilation after clang r315871
v2: use a more generic compat function
v3: rename and formatting cleanup
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103388
Signed-off-by: Jan Vesely <jan.vesely at rutgers.edu>
Reviewed-by: Francisco Jerez <currojerez at riseup.net>
CC: <mesa-stable at lists.freedesktop.org>
(cherry picked from commit a6d38f476beaaf0a9677cfc168172121b5779570)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=87a9a989ee2c3a86faaf0b817e833045917d06b2
Author: Jason Ekstrand <jason.ekstrand at intel.com>
Date: Fri Sep 15 16:22:00 2017 -0700
nir/intrinsics: Set the correct num_indices for load_output
Cc: mesa-stable at lists.freedesktop.org
Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>
(cherry picked from commit c1b84256ccc443a9792893bc780bba970c0dcd4e)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=ce725baa7c90420b46e16087a4f201a7e62b23e5
Author: Matthew Nicholls <mnicholls at feralinteractive.com>
Date: Wed Oct 25 14:20:43 2017 +0100
ac/nir: generate correct instruction for atomic min/max on unsigned images
v2: fix silly typo
Cc: "17.2 17.3" <mesa-stable at lists.freedesktop.org>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
(cherry picked from commit 27a0b24bf238342031e0709584e4d71ab228f1ec)
[Andres Gomez: resolve trivial conflicts]
Signed-off-by: Andres Gomez <agomez at igalia.com>
Conflicts:
src/amd/common/ac_nir_to_llvm.c
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f46ba9ee35265bcbd2b3b9b61ac79e25951eb224
Author: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Date: Sun Oct 22 18:32:14 2017 +0200
ac/nir: Fix nir_texop_lod on GFX for 1D arrays.
Fixes: 1bcb953e166 'radv: handle GFX9 1D textures'
Reviewed-by: Dave Airlie <airlied at redhat.com>
(cherry picked from commit 2c5b43c87fc4e5dcc50f72d782d7b3718e3c2c1c)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=2d51d41865852a78047c36756ea385083292b6dd
Author: Stefan Schake <stschake at gmail.com>
Date: Fri Oct 20 16:16:44 2017 +0200
broadcom/vc4: Fix aliasing issue
This was causing Android clang version 3.8.256229 to miscompile,
presumably due to strict aliasing.
Fixes: 14dc281c1332 ("vc4: Enforce one-uniform-per-instruction after optimization.")
(cherry picked from commit e5fea0d621af2b14cf6c5e364eeaf293db460f2a)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=cbc081b8711a519dd9aa371debbf68aa0add4076
Author: Kenneth Graunke <kenneth at whitecape.org>
Date: Thu Oct 19 14:38:30 2017 -0700
i965: Revert absolute mode for constant buffer pointers.
The kernel doesn't initialize the value of the INSTPM or CS_DEBUG_MODE2
registers at context initialization time. Instead, they're inherited
from whatever happened to be running on the GPU prior to first run of a
new context. So, when we started setting these, other contexts in the
system started inheriting our values. Since this controls whether
3DSTATE_CONSTANT_* takes a pointer or an offset, getting the wrong
setting is fatal for almost any process which isn't expecting this.
Unfortunately, VA-API and Beignet don't initialize this (nor does older
Mesa), so they will die horribly if we start doing this. UXA and SNA
don't use any push constants, so they are unaffected.
Until we have some kind of solution to this problem, I'm going to revert
this patch and abandon using the feature for now. It will lead to fewer
pushed UBO ranges on Broadwell+, which may lead to lower performance,
though I don't have any data on the impact.
Cc: "17.3 17.2" <mesa-stable at lists.freedesktop.org>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102774
(cherry picked from commit 013d33122028f2492da90a03ae4bc1dab84c3ee9)
[Andres Gomez: resolve trivial conflicts]
Signed-off-by: Andres Gomez <agomez at igalia.com>
Conflicts:
src/mesa/drivers/dri/i965/brw_state_upload.c
src/mesa/drivers/dri/i965/intel_screen.c
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=546b4d455ac694000c74057a8eecf9ab8aa7acf6
Author: Michel Dänzer <michel.daenzer at amd.com>
Date: Mon Oct 16 16:35:18 2017 +0200
st/mesa: Initialize textures array in st_framebuffer_validate
And just reference pipe_resources to it in the validate callbacks.
Avoids pipe_resource leaks when st_framebuffer_validate ends up calling
the validate callback multiple times, e.g. when a window is resized.
v2:
* Use generic stable tag instead of Fixes: tag, since the problem could
already happen before the commit referenced in v1 (Thomas Hellstrom)
* Use memset to initialize the array on the stack instead of allocating
the array with os_calloc.
Cc: mesa-stable at lists.freedesktop.org
Reviewed-by: Thomas Hellstrom <thellstrom at vmware.com>
(cherry picked from commit 7561da367baeb49c848dc49b65e252deb6428422)
Squashed with:
st/osmesa: include u_inlines.h for pipe_resource_reference
Fixes build failure due to unresolved symbol.
Fixes: 7561da367bae "st/mesa: Initialize textures array in
st_framebuffer_validate"
Trivial.
(cherry picked from commit 8c9e7c9638278687297fbc6ba4344771d61f721e)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=9cbf8c910e8967334d5f26489b5924025cc03478
Author: Henri Verbeet <hverbeet at gmail.com>
Date: Fri Oct 13 17:10:26 2017 +0200
vulkan/wsi: Free the event in x11_manage_fifo_queues().
Cc: mesa-stable at lists.freedesktop.org
Signed-off-by: Henri Verbeet <hverbeet at gmail.com>
Fixes: e73d136a023 ("vulkan/wsi/x11: Implement FIFO mode.")
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com
(cherry picked from commit 3de87f7cd79b21ef3844670e601af4a60409986b)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=1eb4cbc934afd72ea45521eeac763e43564d972b
Author: Dave Airlie <airlied at redhat.com>
Date: Tue Oct 17 08:17:12 2017 +0100
radv/image: bump all the offset to uint64_t.
So one of the CTS tests tries to allocate a 16384x1 2048 array
texture. This overflows a bunch of calculations when we want it
tiled as the heights goes to 128.
addrlib returns us the correct size (16GB or so), but we mangle
it in the htile calcs due to the 32-bit offset fields, then
userspace gives us the reduced number and we try to allocate
it on a heap and things blow up.
We really need to give the app back the correct size for the
image so we can blow up properly in memory allocation later.
This should fix hangs in
dEQP-VK.pipeline.render_to_image.core.1d_array.huge.width_layers.r8g8b8a8_unorm_d32_sfloat_s8_uint
since
Fixes: ad3d98da9f (radv: enable tc compatible htile for d32s8 also.)
Now there's an open question if we should be enabling tc-compat
htile at all for shallow textures like the above.
This might cause some other wierd side effects in CTS even
without the tc compat so:
Cc: "17.2" <mesa-stable at lists.freedesktop.org>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Signed-off-by: Dave Airlie <airlied at redhat.com>
(cherry picked from commit 35c66f3e40177a97d74e614e2a324a03e2149c73)
[Andres Gomez: resolve trivial conflicts]
Signed-off-by: Andres Gomez <agomez at igalia.com>
Conflicts:
src/amd/vulkan/radv_private.h
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=fba44d91d0c31fb7c531f3443e34956415a14199
Author: Marek Olšák <marek.olsak at amd.com>
Date: Tue Oct 17 03:08:47 2017 +0200
Revert "mesa: fix texture updates for ATI_fragment_shader"
This reverts commit 9d54025cd1eee3f42b80c062d1f644904bf2ba41.
It breaks KOTOR.
Cc: 17.1 17.2 <mesa-stable at lists.freedesktop.org>
(cherry picked from commit 5d071bf04bcf4c35452faaac253cdc9bac31f780)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=9cba4d491cccd1a7bcc13bd5d46089b87ad13cd0
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date: Fri Oct 13 18:20:21 2017 +0200
radv: add the draw count buffer to the list of buffers
My guess is that the GPU is going to report VM faults if
vkCmdDrawIndirectCountAMD() (and friends) are used.
Cc: mesa-stable at lists.freedesktop.org
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
(cherry picked from commit 3e5f27faf3b0702c66f932b3e6ba6301c371e2d1)
More information about the mesa-commit
mailing list