Mesa (master): egl/x11: use the no-op dri2_fallback_copy_buffers for swrast

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Tue Aug 7 17:03:52 UTC 2018


Module: Mesa
Branch: master
Commit: 5463064f7a0864dfaa1599b4d0899bd5f975da39
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=5463064f7a0864dfaa1599b4d0899bd5f975da39

Author: Emil Velikov <emil.velikov at collabora.com>
Date:   Wed Jun 27 18:17:37 2018 +0100

egl/x11: use the no-op dri2_fallback_copy_buffers for swrast

Currently dri2_copy_buffers is used for swrast, which depends on the
DRI2_FLUSH extension. Since that's not a thing on software based
drivers we crash out.

Do the slightly more graceful, thing of returning EGL_FALSE.

Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
Reviewed-by: Eric Engestrom <eric.engestrom at intel.com>

---

 src/egl/drivers/dri2/platform_x11.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/egl/drivers/dri2/platform_x11.c b/src/egl/drivers/dri2/platform_x11.c
index cfa5c4aa2b..cc912d2b71 100644
--- a/src/egl/drivers/dri2/platform_x11.c
+++ b/src/egl/drivers/dri2/platform_x11.c
@@ -1189,7 +1189,8 @@ static const struct dri2_egl_display_vtbl dri2_x11_swrast_display_vtbl = {
    .set_damage_region = dri2_fallback_set_damage_region,
    .swap_buffers_region = dri2_fallback_swap_buffers_region,
    .post_sub_buffer = dri2_fallback_post_sub_buffer,
-   .copy_buffers = dri2_x11_copy_buffers,
+   /* XXX: should really implement this since X11 has pixmaps */
+   .copy_buffers = dri2_fallback_copy_buffers,
    .query_buffer_age = dri2_fallback_query_buffer_age,
    .query_surface = dri2_query_surface,
    .create_wayland_buffer_from_image = dri2_fallback_create_wayland_buffer_from_image,




More information about the mesa-commit mailing list