Mesa (18.2): swr: Remove unnecessary memset call

[GitLab Mirror]

Module: Mesa
Branch: 18.2
Commit: 2e903df72fcc54b03c113e7a52ac33034dfecf86
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=2e903df72fcc54b03c113e7a52ac33034dfecf86

Author: Vlad Golovkin <vlad.golovkin.mail at gmail.com>
Date:   Wed Aug  1 20:56:23 2018 +0300

swr: Remove unnecessary memset call

Zeroing memory after calloc is not necessary. This also allows to avoid
possible crash when allocation fails, because memset is called before
checking screen for NULL.

Fixes: a29d63ecf71546c4798c6 "swr: refactor swr_create_screen to allow
                              for proper cleanup on error"
Reviewed-by: Eric Engestrom <eric.engestrom at intel.com>
(cherry picked from commit 9d3a2394e4d3f91f1e23a971ce34aaf031a1e777)

---

 src/gallium/drivers/swr/swr_screen.cpp | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/gallium/drivers/swr/swr_screen.cpp b/src/gallium/drivers/swr/swr_screen.cpp
index fa232b6838..67085444f8 100644
--- a/src/gallium/drivers/swr/swr_screen.cpp
+++ b/src/gallium/drivers/swr/swr_screen.cpp
@@ -1148,7 +1148,6 @@ struct pipe_screen *
 swr_create_screen_internal(struct sw_winsys *winsys)
 {
    struct swr_screen *screen = CALLOC_STRUCT(swr_screen);
-   memset(screen, 0, sizeof(struct swr_screen));
 
    if (!screen)
       return NULL;