Mesa (18.2): 24 new commits

Wed Aug 15 11:54:28 UTC 2018

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=dcd3786e6ed3574fade9b06c3e2cf1bd030aaf7a
Author: Andres Gomez <agomez at igalia.com>
Date:   Wed Aug 15 14:53:50 2018 +0300

    Update version to 18.2.0-rc3

    Signed-off-by: Andres Gomez <agomez at igalia.com>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=d82c36a4c7f561b4bfde7ab57f925214d290c8ee
Author: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Date:   Sat Jul 28 14:01:42 2018 +0200

    radv: Allow ETC2 on RAVEN and VEGA10 instead of all GFX9.

    Follow radeonsi.

    Fixes: 3665f66ef26 "radv: Add support for ETC2 textures."
    Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
    (cherry picked from commit 4bb6c49375ecc36b32331cc53f90c89d0eb4c8f0)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=8061ee5883e62cd019d6e1d8afd8ac866a547544
Author: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Date:   Mon Jul 23 16:24:02 2018 +0200

    radv: Update to new VK_EXT_vertex_attribute_divisor to version 2.

    Behavior wrt firstInstance got changed, and a divisor of 0 has been
    disallowed.

    The new version of the ext got published in specification 1.1.81.

    Sending to stable since the only known user is DXVK, which needs
    this for correctness.

    Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
    CC: 18.2 <mesa-stable at lists.freedesktop.org>
    (cherry picked from commit 66e12451ac4e4e1c05a48b2cd2b0d3186f779f20)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=bbd95de921b443b6c63cbe1ff7d246c7428d9b6e
Author: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Date:   Fri Aug 10 02:26:19 2018 +0200

    radv: Fix missing Android platform define.

    CC: <mesa-stable at lists.freedesktop.org>
    Acked-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
    (cherry picked from commit bf33ca751252e9735418e33bacd257a8b431b102)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=b696ab172c95a6fb8ad739279fe386855b048c60
Author: Kenneth Graunke <kenneth at whitecape.org>
Date:   Thu Aug 9 23:28:24 2018 -0700

    blorp: Properly handle Z24X8 blits.

    One of the reasons we didn't notice that R24_UNORM_X8_TYPELESS
    destinations were broken was that an earlier layer was swapping it
    out for B8G8R8A8_UNORM.  That made Z24X8 -> Z24X8 blits work.

    However, R32_FLOAT -> R24_UNORM_X8_TYPELESS was still totally broken.
    The old code only considered one format at a time, without thinking
    that format conversion may need to occur.

    This patch moves the translation out to a place where it can consider
    both formats.  If both are Z24X8, we continue using B8G8R8A8_UNORM to
    avoid having to do shader math workarounds.  If we have a Z24X8
    destination, but a non-matching source, we use our shader hacks to
    actually render to it properly.

    Fixes: 804856fa5735164cc0733ad0ea62adad39b00ae2 (intel/blorp: Handle more exotic destination formats)
    Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
    (cherry picked from commit de57926dc909b3fb180ff06a6c5235309fdbf4df)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=f7e8bc0f23ee9e81c686885f97e153c721c88eef
Author: Kenneth Graunke <kenneth at whitecape.org>
Date:   Thu Aug 9 23:11:07 2018 -0700

    blorp: Don't try to use R32_UNORM for R24_UNORM_X8_TYPELESS rendering.

    The hardware doesn't support rendering to R24_UNORM_X8_TYPELESS, so
    Jason decided to fake it with a bit of shader math and R32_UNORM RTs.

    The only problem is that R32_UNORM isn't renderable either...so we've
    just traded one bad format for another.

    This patch makes us use R32_UINT instead.

    Fixes: 804856fa5735164cc0733ad0ea62adad39b00ae2 (intel/blorp: Handle more exotic destination formats)
    Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
    (cherry picked from commit 8a290862859bade4b238f595378d63bb920e763a)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=90278c7f951e9bb9909c0e7a0fd543fa59643600
Author: Jason Ekstrand <jason.ekstrand at intel.com>
Date:   Mon Jul 23 08:02:46 2018 -0700

    intel: Switch the order of the 2x MSAA sample positions

    The Vulkan 1.1.82 spec flipped the order to better match D3D.

    Cc: mesa-stable at lists.freedesktop.org
    Reviewed-by: Iago Toral Quiroga <itoral at igalia.com>
    Reviewed-by: Anuj Phogat <anuj.phogat at gmail.com>
    (cherry picked from commit a9f7bcfdf90d8302e9ed27601b2b7001b9940740)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=0c1832765f491f52acde43553f05fae1a136d806
Author: Gert Wollny <gert.wollny at collabora.com>
Date:   Thu Aug 9 12:46:52 2018 +0200

    mesa/st: ETC2 now uses R8G8B8A8_SRGB as fallback

    The check for ETC2 compatibility was not updated when the fallback
    format was changed.

    Fixes: 71867a0a61cea20bf3f6115692e70b0d60f0b70d
       st/mesa: Fall back to R8G8B8A8_SRGB for ETC2

    Signed-off-by: Gert Wollny <gert.wollny at collabora.com>
    Reviewed-by: Marek Olšák <marek.olsak at amd.com>
    (cherry picked from commit e94095ec30462d4264c6d7c7dd4fbf8bc0d99c69)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=94da4547260642234b78e2f9022a496aadae8e2a
Author: Eric Anholt <eric at anholt.net>
Date:   Tue Aug 7 11:37:28 2018 -0700

    egl: Fix leak of X11 pixmaps backing pbuffers in DRI3.

    This is basically copied from the DRI2 destroy path.  Without this,
    Raspberry Pi would quickly run out of CMA during the EGL tests in the CTS
    due to all the pixmaps laying around.

    Fixes: f35198badeb9 ("egl/x11: Implement dri3 support with loader's dri3 helper")
    Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
    Reviewed-by: Eric Engestrom <eric.engestrom at intel.com>
    (cherry picked from commit b618d7ea59a4d7da9823e02ac5608a67fd99b332)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=dadc50add58609fb20e905dfc25d58d0dfe6fff1
Author: Kenneth Graunke <kenneth at whitecape.org>
Date:   Thu Aug 2 15:02:18 2018 -0700

    intel: Fix SIMD16 unaligned payload GRF reads on Gen4-5.

    When the SIMD16 Gen4-5 fragment shader payload contains source depth
    (g2-3), destination stencil (g4), and destination depth (g5-6), the
    single register of stencil makes the destination depth unaligned.

    We were generating this instruction in the RT write payload setup:

       mov(16)   m14<1>F   g5<8,8,1>F   { align1 compr };

    which is illegal, instructions with a source region spanning more than
    one register need to be aligned to even registers.  This is because the
    hardware implicitly does (nr | 1) instead of (nr + 1) when splitting the
    compressed instruction into two mov(8)'s.

    I believe this would cause the hardware to load g5 twice, replicating
    subspan 0-1's destination depth to subspan 2-3.  This showed up as 2x2
    artifact blocks in both TIS-100 and Reicast.

    Normally, we rely on the register allocator to even-align our virtual
    GRFs.  But we don't control the payload, so we need to lower SIMD widths
    to make it work.  To fix this, we teach lower_simd_width about the
    restriction, and then call it again after lower_load_payload (which is
    what generates the offending MOV).

    Fixes: 8aee87fe4cce0a883867df3546db0e0a36908086 (i965: Use SIMD16 instead of SIMD8 on Gen4 when possible.)
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107212
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=13728
    Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
    Tested-by: Diego Viola <diego.viola at gmail.com>
    (cherry picked from commit 08a5c395abdafd0d7556060596f78c238b4a989f)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=e91782ed556b86e48d67e68fbfaad6116577abb6
Author: Adam Jackson <ajax at redhat.com>
Date:   Tue Dec 5 11:10:09 2017 -0500

    glx: GLX_MESA_multithread_makecurrent is direct-only

    This extension is not defined for indirect contexts. Marking it as
    "client only", as the old code did here, would make the extension
    available in indirect contexts, even though the server would certainly
    not have it in its extension list.

    Cc: <mesa-stable at lists.freedesktop.org>
    Signed-off-by: Adam Jackson <ajax at redhat.com>
    Reviewed-by: Nicolai Hähnle <nicolai.haehnle at amd.com>
    Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
    (cherry picked from commit 63a6b719d98fb1ad58ae93c2de859e6d4bfa8b8b)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=9df3460724db4577aa1a105fa0978e128b4924c5
Author: Tapani Pälli <tapani.palli at intel.com>
Date:   Tue Aug 7 08:20:29 2018 +0300

    glsl: handle error case with ast_post_inc, ast_post_dec

    Return ir_rvalue::error_value with ast_post_inc, ast_post_dec if
    parser error was emitted previously. This way process_array_size
    won't see bogus IR generated like with commit 9c676a64273.

    Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98699
    Reviewed-by: Iago Toral Quiroga <itoral at igalia.com>
    (cherry picked from commit 03a5acec687454c7fe227b4bdd2db97d515f1af7)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=8be5985e65bbcb070882db4a59fc0bf79c13581f
Author: vadym.shovkoplias <vadim.shovkoplias at gmail.com>
Date:   Mon Aug 6 15:52:13 2018 +0300

    drirc: Allow extension midshader for Metro Redux

    This fixes both Metro 2033 Redux and Metro Last Light Redux

    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99730
    Signed-off-by: Eero Tamminen <eero.t.tamminen at intel.com>
    Signed-off-by: Vadym Shovkoplias <vadym.shovkoplias at globallogic.com>
    Reviewed-by: Tapani Pälli <tapani.palli at intel.com>
    (cherry picked from commit e0de26eacc93f431962533f50d57e58335843d6b)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=6606cacd3d96a0b87a3ce6ee7d85b37eec37caea
Author: Eric Engestrom <eric.engestrom at intel.com>
Date:   Wed Aug 8 15:26:32 2018 +0100

    intel/tools: add missing variable initialisation

    Fixes: 6a60beba4089315685b8 "intel/tools: Add an error state to aub translator"
    Signed-off-by: Eric Engestrom <eric.engestrom at intel.com>
    Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
    (cherry picked from commit aac80f75973b61a8a31f873a9de6bcf294ea493c)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=1378f33142123f6f5b96ce1d4ac5e8e2440ea6a2
Author: Eric Anholt <eric at anholt.net>
Date:   Tue Aug 7 12:15:03 2018 -0700

    vc4: Fix vc4_fence_server_sync() on pre-syncobj kernels.

    We won't have an FD if we're just having the server wait on a fence
    created by eglCreateSyncKHR().  Our seqno fences will happen in order, so
    server-side waits are no-ops in that case.  Fixes
    dEQP-EGL.functional.sharing.gles2.multithread.simple_egl_server_sync.buffers.gen_delete

    Fixes: b0acc3a5628c ("broadcom/vc4: Native fence fd support")
    (cherry picked from commit cfe69d0aaafadaaaca98517bc33307fba68197ba)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=9dacf10ca8165ca49c812ea82492dbf3e1d2a74c
Author: Emil Velikov <emil.velikov at collabora.com>
Date:   Mon Jan 22 17:52:49 2018 +0000

    swr: don't export swr_create_screen_internal

    With earlier rework the user and provider of the symbol are within the
    same binary. Thus there's no point in exporting the function.

    Spotted while reviewing patch from Chuck, that nearly added another
    unneeded PUBLIC function.

    Cc: Chuck Atkins <chuck.atkins at kitware.com>
    Cc: Tim Rowley <timothy.o.rowley at intel.com>
    Fixes: f50aa21456d "(swr: build driver proper separate from rasterizer")
    Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
    Tested-by: Chuck Atkins <chuck.atkins at kitware.com>
    Reviewed-By: George Kyriazis <george.kyriazis at intel.com<mailto:george.kyriazis at intel.com>>
    Tested-by: Chuck Atkins <chuck.atkins at kitware.com<mailto:chuck.atkins at kitware.com>>
    (cherry picked from commit 54d844897fe0afea4b5ddf08565af49a8191d808)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=7af6be8864d7d8fecd61750c43751df0989a9416
Author: Juan A. Suarez Romero <jasuarez at igalia.com>
Date:   Wed Jun 6 10:13:05 2018 +0000

    wayland/egl: update surface size on window resize

    According to EGL 1.5 spec, section 3.10.1.1 ("Native Window Resizing"):

      "If the native window corresponding to _surface_ has been resized
       prior to the swap, _surface_ must be resized to match. _surface_ will
       normally be resized by the EGL implementation at the time the native
       window is resized. If the implementation cannot do this transparently
       to the client, then *eglSwapBuffers* must detect the change and
       resize surface prior to copying its pixels to the native window."

    So far, resizing a native window in Wayland/EGL was interpreted in Mesa
    as a request to resize, which is not executed until the first draw call.
    And hence, surface size is not updated until executing it. Thus,
    querying the surface size with eglQuerySurface() after a window resize
    still returns the old values.

    This commit updates the surface size values as soon as the resize is
    done, even when the real resize is done in the draw call. This makes the
    semantics that any native window resize request take effect inmediately,
    and if user calls eglQuerySurface() it will return the new resized
    values.

    v2: update surface size if there isn't a back surface (Daniel)

    CC: Daniel Stone <daniel at fooishbar.org>
    CC: mesa-stable at lists.freedesktop.org
    Reviewed-by: Daniel Stone <daniels at collabora.com>
    (cherry picked from commit a9fb331ea7d1a78936ea8d8385e44cfd66f835c1)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=9ad14f71e6000249affc8e991db878e0e9e1ba19
Author: Juan A. Suarez Romero <jasuarez at igalia.com>
Date:   Mon Jun 4 10:22:49 2018 +0000

    wayland/egl: initialize window surface size to window size

    When creating a windows surface with eglCreateWindowSurface(), the
    width and height returned by eglQuerySurface(EGL_{WIDTH,HEIGHT}) is
    invalid until buffers are updated (like calling glClear()).

    But according to EGL 1.5 spec, section 3.5.6 ("Surface Attributes"):

      "Querying EGL_WIDTH and EGL_HEIGHT returns respectively the width and
       height, in pixels, of the surface. For a window or pixmap surface,
       these values are initially equal to the width and height of the
       native window or pixmap with respect to which the surface was
       created"

    This fixes dEQP-EGL.functional.color_clears.* CTS tests

    v2:
    - Do not modify attached_{width,height} (Daniel)
    - Do not update size on resizing window (Brendan)

    CC: Daniel Stone <daniel at fooishbar.org>
    CC: Brendan King <brendan.king at imgtec.com>
    CC: mesa-stable at lists.freedesktop.org
    Tested-by: Eric Engestrom <eric at engestrom.ch>
    Tested-by: Chad Versace <chadversary at chromium.org>
    Reviewed-by: Chad Versace <chadversary at chromium.org>
    Reviewed-by: Daniel Stone <daniels at collabora.com>
    (cherry picked from commit 1fe7cbdf05b90034577dac4e4aa6157031d80521)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=6ae0a639ec3a000bc4106152e288f419386d75cb
Author: Emil Velikov <emil.velikov at collabora.com>
Date:   Fri Feb 23 19:32:08 2018 +0000

    autotools: use correct gl.pc LIBS when using glvnd

    This is more of a hack, since glvnd itself should be providing the file.
    Until that happens, ensure the libs is correctly set to -lGL

    CC: <mesa-stable at lists.freedesktop.org>
    Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
    Reviewed-by: Adam Jackson <ajax at redhat.com>
    (cherry picked from commit 315c46cfdc3dbd4d51b74ab26df693725e947724)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=c70920697759f3c5257806168be9009364025cf4
Author: Emil Velikov <emil.velikov at collabora.com>
Date:   Fri Feb 23 19:32:05 2018 +0000

    autotools: error out when building with mangling and glvnd

    It's not a thing that can work, nor is a wise idea to attempt.

    v2: Tweak error message (Dylan)

    CC: <mesa-stable at lists.freedesktop.org>
    Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
    Reviewed-by: Adam Jackson <ajax at redhat.com> (v1)
    (cherry picked from commit 25a9450a44b3b572fba81e6cafe33f3367252499)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=33ac5fb67829b494a78806fc07b8824cbd29bb9e
Author: Emil Velikov <emil.velikov at collabora.com>
Date:   Fri Feb 23 19:32:04 2018 +0000

    autotools: error out when using the broken --with-{gl, osmesa}-lib-name

    The toggles were broken with the introduction of --enable-mangling.
    Fixing that up might be possible, but it's not worth the complexity
    since one can rename the libraries at any point.

    CC: <mesa-stable at lists.freedesktop.org>
    Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
    Reviewed-by: Adam Jackson <ajax at redhat.com>
    (cherry picked from commit d5ac23647110fd530f9bf5002762587be446866d)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=f0ae95492ad4def099acd16c712192d61f597fea
Author: Emil Velikov <emil.velikov at collabora.com>
Date:   Fri Feb 23 19:32:00 2018 +0000

    automake: require shared glapi when using DRI based libGL

    This has been a requirement for ages, yet it seems like we never
    explicitly errored out during configure.

    CC: <mesa-stable at lists.freedesktop.org>
    Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
    Reviewed-by: Adam Jackson <ajax at redhat.com>
    (cherry picked from commit a7ea7511ba76c0a83eec84dfc9c14c82b5c82dc4)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=a42afc8504ee1891780b2cc615ca1183357d5948
Author: Eric Anholt <eric at anholt.net>
Date:   Tue Aug 7 13:47:08 2018 -0700

    vc4: Ignore samplers for finding uniform offsets.

    Fixes:
    dEQP-GLES2.shaders.struct.uniform.sampler_array_fragment
    dEQP-GLES2.shaders.struct.uniform.sampler_array_vertex
    dEQP-GLES2.shaders.struct.uniform.sampler_nested_fragment
    dEQP-GLES2.shaders.struct.uniform.sampler_nested_vertex

    Cc: mesa-stable at lists.freedesktop.org
    (cherry picked from commit 69158c452bb39cd3d12110dd623aff09e771fa77)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=adfbf1fe84e2777b7ad55a60625e478469a06d05
Author: Eric Anholt <eric at anholt.net>
Date:   Tue Aug 7 12:59:14 2018 -0700

    vc4: Respect a sampler view's first_layer field.

    Fixes texturing from EGL images created from cubemap faces, as in
    dEQP-EGL.functional.image.create.gles2_cubemap_negative_x_rgba_texture

    Cc: mesa-stable at lists.freedesktop.org
    (cherry picked from commit 9ab6912a00ec29f5d1d9cebc7d3e32ae235419e8)